Re: [PATCH 2/2] driver-core: remove the duplicate assignment of kobj->parent in device_add

Bjørn Mork
2013-03-07T14:50:48Z

[ not stripping any quoting to restore context for linux-kernel]

Wei Yang <weiyang@linux.vnet.ibm.com> writes:
> On Thu, Mar 07, 2013 at 12:33:19PM +0100, Bjørn Mork wrote:
>>Wei Yang <weiyang@linux.vnet.ibm.com> writes:
>>
>>> kobject_add() will setup the kobject parent correctly.
>>>
>>> This patch removes the redundant code.
>>>
>>> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>>> Reviewed-by: Ram Pai <linuxram@us.ibm.com>
>>> Reviewed-by: Gavin Shan <shangw@linux.vnet.ibm.com>
>>> ---
>>> drivers/base/core.c | 4 +---
>>> 1 files changed, 1 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>>> index 369ae4e..6b0a859 100644
>>> --- a/drivers/base/core.c
>>> +++ b/drivers/base/core.c
>>> @@ -1024,8 +1024,6 @@ int device_add(struct device *dev)
>>>
>>> parent = get_device(dev->parent);
>>> kobj = get_device_parent(dev, parent);
>>> - if (kobj)
>>> - dev->kobj.parent = kobj;
>>>
>>> /* use parent numa_node */
>>> if (parent)
>>> @@ -1033,7 +1031,7 @@ int device_add(struct device *dev)
>>>
>>> /* first, register with generic layer. */
>>> /* we require the name to be set before, and pass NULL */
>>> - error = kobject_add(&dev->kobj, dev->kobj.parent, NULL);
>>> + error = kobject_add(&dev->kobj, kobj, NULL);
>>> if (error)
>>> goto Error;
>>
>>
>>You've submitted this exact same patch before and Greg asked a couple of
>>questions about it: https://lkml.org/lkml/2013/1/25/599
>>
>>If this is a resubmission, then it would sure be nice if that was clear
>>from the subject and on. And I believe any previously asked questions
>>should be answered in some way. I see that you have responded to one of
>>them by moving part of the commit message to the cover letter, but still
>>without any answer to the question.
>>
>>To me this looks like you completely ignored Greg's review questions. Is
>>that so?
>
> Bjør,
>
> Thanks for your response.
>
> In my mail box, I just see one mail from Greg and replied. Below is my screen
> in my mutt. You see I replied and wait for the further comment for several
> days and send out another reply on Feb 02. Well not receive further comment.
>
> 976 Jan 23 Wei Yang ( 37) [PATCH] driver-core: remove the duplicate assignment of kobj->parent in device_add
> 977 r Jan 25 Greg KH ( 17) `->
> 978 r Jan 28 Wei Yang ( 43) `->
> 979 Feb 02 Wei Yang ( 52) `->
>
> Hmm... I am confused with this, maybe my mail box get some problem.
> Could you see this mail? Or if someone could see this mail, would you please
> reply so that I will be sure that I have really sent it out .
>
> BTW, no one see my reply? I looked in the url you mentioned, really not see my
> reply. I am sorry for that.

I cannot answer where your reply may have gone. I do however note that
this reply to me went to every address on the CC list *except*
linux-kernel@vger.kernel.org. Why? That would make it appear as you
never answered me to 99.999997% of the linux-kernel readers...

Anyway, the main point is really not whether your mail went anywhere or
not. If this was indeed an intentional resend, then I do expect it to
say so and to contain information about how previous review comments
were resolved. Most people would not rememeber your answer even it was
sent to the mailing list.

Bjørn