public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: Lingzhu Xiang <lxiang@redhat.com>
Cc: Matt Fleming <matt@console-pimps.org>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Michael Schroeder <mls@suse.com>, Josh Boyer <jwboyer@redhat.com>,
	Peter Jones <pjones@redhat.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Frederic Crozat <fcrozat@suse.com>
Subject: Re: [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash
Date: Thu, 07 Mar 2013 16:03:47 +0800	[thread overview]
Message-ID: <1362643427.28562.16.camel@linux-s257.site> (raw)
In-Reply-To: <51370A51.1050505@redhat.com>

於 三，2013-03-06 於 17:20 +0800，Lingzhu Xiang 提到：
> On 03/06/2013 03:34 PM, joeyli wrote:
> > +static unsigned long variable_name_length(efi_char16_t *variable_name)
> > +{
> > +	unsigned long len;
> > +	efi_char16_t c;
> > +
> > +	len = 2;
> > +	do {
> > +		c = variable_name[len / sizeof(c) - 1];
> > +		if (c)
> > +			len += sizeof(c);
> > +	} while (c);
> > +
> > +	return len;
> > +}
> > +
> 
> It looks like this function can be replaced with utf16_strsize.
> 

Ah! thanks for you point out, I will use utf16_strsize.


Thanks a lot!
Joey Lee



  parent reply	other threads:[~2013-03-07  8:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01  3:20 [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash Lee, Chun-Yi
2013-03-01  9:31 ` Lingzhu Xiang
2013-03-01 14:49   ` joeyli
2013-03-01 15:17 ` Matt Fleming
2013-03-01 16:31   ` Matt Fleming
2013-03-01 23:41     ` joeyli
2013-03-06  7:34       ` joeyli
2013-03-06  7:39         ` joeyli
2013-03-06  9:20         ` Lingzhu Xiang
2013-03-06 11:21           ` Matt Fleming
2013-03-07  8:03           ` joeyli [this message]
2013-03-06 11:19         ` Matt Fleming
2013-03-06 11:58           ` Frederic Crozat
2013-03-06 12:36             ` Matt Fleming
2013-03-06 13:30               ` Frederic Crozat
2013-03-06 13:38                 ` Matt Fleming
2013-03-07 10:34           ` joeyli
2013-03-07 11:39             ` Matt Fleming
2013-03-07 13:57               ` Matt Fleming
2013-03-07 14:03                 ` joeyli
2013-03-11 13:17                 ` joeyli
2013-03-18 15:29                   ` Matt Fleming
2013-03-08  6:37               ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362643427.28562.16.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=fcrozat@suse.com \
    --cc=jwboyer@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lxiang@redhat.com \
    --cc=matt@console-pimps.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=mls@suse.com \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox