Re: [PATCH 00/10] dmatest: update the module to use debugfs

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2013-03-07 at 11:50 +0530, Vinod Koul wrote: 
> On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
> > The first approach to get dmatest module more flexible and easier to play with.
> > The amount of patches could be reduced, but I would like to get a comments
> > first on smaller pieces. The entire series creates dmatest.txt file in the
> > Documentation folder. Similar description is scattered through the commit
> > messages.
> > 
> > Module was tested on Intel Medfield and Lynxpoint systems with dw_dmac DMA
> > controller embedded.
> Overall the series looks good. I think it can applied in this form as well.

Viresh, so, you are the only one who speaks about reducing amount of
patches. Do you think is better to either reduce, or leave as is? In
case of go with smaller amount, could you provide simple scheme which
patch should be merged with which?


> > 
> > Andy Shevchenko (10):
> >   dmatest: cancel thread immediately when asked for
> >   dmatest: allocate memory for pq_coefs from heap
> >   dmatest: create dmatest_info to keep test parameters
> >   dmatest: move dmatest_channels and nr_channels to dmatest_info
> >   dmatest: split test parameters to separate structure
> >   dmatest: run test via debugfs
> >   dmatest: return actual state in 'run' file
> >   dmatest: define MAX_ERROR_COUNT constant
> >   dmatest: gather test results in the linked list
> >   dmatest: append verify result to results
> > 
> >  Documentation/dmatest.txt |  81 +++++
> >  drivers/dma/dmatest.c     | 887 +++++++++++++++++++++++++++++++++++++++-------
> >  2 files changed, 832 insertions(+), 136 deletions(-)
> >  create mode 100644 Documentation/dmatest.txt

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy