Re: [PATCH 05/16] TTY: add tty_port_tty_wakeup helper

Greg KH
2013-03-18T23:15:29Z

On Fri, Mar 08, 2013 at 08:02:09PM +0100, Jiri Slaby wrote:
> On 03/08/2013 04:02 PM, Peter Hurley wrote:
> > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote:
> >> It allows for cleaning up on a considerable amount of places. They did
> >> port_get, wakeup, kref_put. Now the only thing needed is to call
> >> tty_port_tty_wakeup which does exactly that.
> >>
> >> One exception is ifx6x60 where tty_wakeup was open-coded. We now call
> >> tty_wakeup properly there.
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> >> ---
> >> arch/um/drivers/line.c | 8 +-------
> >
> > Cc: Jeff Dike <jdike@addtoit.com>
> > Cc: Richard Weinberger <richard@nod.at>
> >
> >> drivers/isdn/capi/capi.c | 7 +------
> >
> > Cc: Karsten Keil <isdn@linux-pingi.de>
> >
> >> drivers/isdn/gigaset/interface.c | 6 +-----
> >
> > Cc: Hansjoerg Lipp <hjlipp@web.de>
> > Cc: Tilman Schmidt <tilman@imap.cc>
> > Cc: gigaset307x-common@lists.sourceforge.net
> > Cc: netdev@vger.kernel.org
> >
> >> drivers/net/usb/hso.c | 13 ++-----------
> >
> > Cc: Jan Dumon <j.dumon@option.com>
> > Cc: linux-usb@vger.kernel.org
> >
> >> drivers/s390/char/sclp_tty.c | 9 ++-------
> >> drivers/s390/char/sclp_vt220.c | 8 +-------
> >
> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: linux390@de.ibm.com
> > Cc: linux-s390@vger.kernel.org
> >
> >> drivers/staging/fwserial/fwserial.c | 10 ++--------
> >
> > Cc: Me :)
> >
> >> drivers/staging/serqt_usb2/serqt_usb2.c | 7 +------
> >
> > Cc: YAMANE Toshiaki <yamanetoshi@gmail.com>
> > Cc: Devendra Naga <devendra.aaru@gmail.com>
> >
> > and so on...
> >
> > Same for the other mega-patches.
>
> I'm not sure whether to CC all the people for such patches. I always
> tended not to and instead rely on people reading LKML :P.
>
> If this is the preferred way, I of course can do it next time.

It's nice to at least cc: driver maintainers if you can, you can script
get_maintainers.pl to do this for you. But don't worry about it this
time.

thanks,

greg k-h