Re: [PATCH 10/16] TTY: cleanup tty->hw_stopped uses

Peter Hurley
2013-03-08T14:55:48Z

On Fri, 2013-03-08 at 15:46 +0100, Jiri Slaby wrote:
> On 03/08/2013 03:39 PM, Peter Hurley wrote:
> > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote:
> >> --- a/drivers/net/caif/caif_serial.c
> >> +++ b/drivers/net/caif/caif_serial.c
> >> @@ -88,7 +88,6 @@ static inline void update_tty_status(struct ser_device *ser)
> >> {
> >> ser->tty_status =
> >> ser->tty->stopped << 5 |
> >> - ser->tty->hw_stopped << 4 |
> >> ser->tty->flow_stopped << 3 |
> >> ser->tty->packet << 2 |
> >> ser->tty->port->low_latency << 1 |
> >
> > I would maybe leave this with a code comment instead.
> >
> > ser->tty->hw_stopped << 4 | /* hw_stopped is not used by tty layer */
>
> Yeah, maybe...

Plus this is documented in Documentation/networking/caif/README

> >> @@ -4256,9 +4251,6 @@ static void seq_line_info(struct seq_file *m, struct e100_serial *info)
> >> if (info->port.tty->stopped)
> >> seq_printf(m, " stopped:%i",
> >> (int)info->port.tty->stopped);
> >> - if (info->port.tty->hw_stopped)
> >> - seq_printf(m, " hw_stopped:%i",
> >> - (int)info->port.tty->hw_stopped);
> >
> > User-space visible. Tool may expect this field.
>
> I thought that on the first glance too. But look what does that whole
> seq_printf depend on.

Oh, right, duh. That field's never been printed :)