From: Peter Hurley <peter@hurleysoftware.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/16] TTY: cleanup tty->hw_stopped uses
Date: Fri, 08 Mar 2013 09:55:37 -0500 [thread overview]
Message-ID: <1362754537.4219.24.camel@thor.lan> (raw)
In-Reply-To: <5139F9B2.1070909@suse.cz>
On Fri, 2013-03-08 at 15:46 +0100, Jiri Slaby wrote:
> On 03/08/2013 03:39 PM, Peter Hurley wrote:
> > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote:
> >> --- a/drivers/net/caif/caif_serial.c
> >> +++ b/drivers/net/caif/caif_serial.c
> >> @@ -88,7 +88,6 @@ static inline void update_tty_status(struct ser_device *ser)
> >> {
> >> ser->tty_status =
> >> ser->tty->stopped << 5 |
> >> - ser->tty->hw_stopped << 4 |
> >> ser->tty->flow_stopped << 3 |
> >> ser->tty->packet << 2 |
> >> ser->tty->port->low_latency << 1 |
> >
> > I would maybe leave this with a code comment instead.
> >
> > ser->tty->hw_stopped << 4 | /* hw_stopped is not used by tty layer */
>
> Yeah, maybe...
Plus this is documented in Documentation/networking/caif/README
> >> @@ -4256,9 +4251,6 @@ static void seq_line_info(struct seq_file *m, struct e100_serial *info)
> >> if (info->port.tty->stopped)
> >> seq_printf(m, " stopped:%i",
> >> (int)info->port.tty->stopped);
> >> - if (info->port.tty->hw_stopped)
> >> - seq_printf(m, " hw_stopped:%i",
> >> - (int)info->port.tty->hw_stopped);
> >
> > User-space visible. Tool may expect this field.
>
> I thought that on the first glance too. But look what does that whole
> seq_printf depend on.
Oh, right, duh. That field's never been printed :)
next prev parent reply other threads:[~2013-03-08 14:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 12:12 [PATCH 01/16] TTY: jsm, remove superfluous check Jiri Slaby
2013-03-07 12:12 ` [PATCH 02/16] TTY: synclink, " Jiri Slaby
2013-03-07 12:12 ` [PATCH 03/16] TTY: do not warn about setting speed via SPD_* Jiri Slaby
2013-03-07 12:12 ` [PATCH 04/16] TTY: msm_smd_tty, clean up activate/shutdown Jiri Slaby
2013-03-07 12:12 ` [PATCH 05/16] TTY: add tty_port_tty_wakeup helper Jiri Slaby
2013-03-08 15:02 ` Peter Hurley
2013-03-08 19:02 ` Jiri Slaby
2013-03-18 23:16 ` Greg KH
2013-03-07 12:12 ` [PATCH 06/16] TTY: add tty_port_tty_hangup helper Jiri Slaby
2013-03-07 12:12 ` [PATCH 07/16] TTY: quatech2, remove unneeded is_open Jiri Slaby
2013-03-13 13:46 ` Bill Pemberton
2013-03-13 14:17 ` Jiri Slaby
2013-03-13 14:27 ` Bill Pemberton
2013-03-07 12:12 ` [PATCH 08/16] TTY: serial/bfin_uart, unbreak build with KGDB enabled Jiri Slaby
2013-03-08 7:59 ` Sonic Zhang
2013-03-07 12:12 ` [PATCH 09/16] TTY: serial/msm_serial_hs, remove unused tty Jiri Slaby
2013-03-07 12:12 ` [PATCH 10/16] TTY: cleanup tty->hw_stopped uses Jiri Slaby
2013-03-08 14:39 ` Peter Hurley
2013-03-08 14:46 ` Jiri Slaby
2013-03-08 14:55 ` Peter Hurley [this message]
2013-03-07 12:12 ` [PATCH 11/16] crisv10: stop returning info from handle_ser_rx_interrupt Jiri Slaby
2013-03-08 15:06 ` Peter Hurley
2013-03-07 12:12 ` [PATCH 12/16] crisv10: use flags from tty_port Jiri Slaby
2013-03-07 12:12 ` [PATCH 13/16] crisv10: remove unused members Jiri Slaby
2013-03-07 12:12 ` [PATCH 14/16] crisv10: use close delays from tty_port Jiri Slaby
2013-03-07 12:12 ` [PATCH 15/16] crisv10: use *_wait " Jiri Slaby
2013-03-07 12:12 ` [PATCH 16/16] crisv10: use counts " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362754537.4219.24.camel@thor.lan \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox