From: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
To: matt@console-pimps.org
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee,
Chun-Yi" <jlee@suse.com>, Seiji Aguchi <seiji.aguchi@hds.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Lingzhu Xiang <lxiang@redhat.com>
Subject: [PATCH] efivars: allow efi pstore variable when validate filename
Date: Tue, 12 Mar 2013 02:57:28 +0800 [thread overview]
Message-ID: <1363028248-27788-1-git-send-email-jlee@suse.com> (raw)
We mount efivarfs fail after pstore generated 'dump-type*' variables and
reboot.
This issue introduced by commit 47f531e8ba3bc3901a0c493f4252826c41dea1a1
(efivarfs: Validate filenames much more aggressively)
The pstore variable is 'dump-type*-*-*-*-GUID'style, it could not pass
the "GUID should be right after the first '-'" check. This patch allow
the variable name that has 'dump-type' pass the name check.
Cc: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Lingzhu Xiang <lxiang@redhat.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
drivers/firmware/efivars.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 3edade0..ab07f7f 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -930,7 +930,7 @@ static bool efivarfs_valid_name(const char *str, int len)
return false;
/* GUID should be right after the first '-' */
- if (s - 1 != strchr(str, '-'))
+ if (s - 1 != strchr(str, '-') && !strstarts(str, "dump-type"))
return false;
/*
--
1.6.4.2
next reply other threads:[~2013-03-11 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 18:57 Lee, Chun-Yi [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-11 19:00 [PATCH] efivars: allow efi pstore variable when validate filename Lee, Chun-Yi
2013-03-12 3:06 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363028248-27788-1-git-send-email-jlee@suse.com \
--to=joeyli.kernel@gmail.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lxiang@redhat.com \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=seiji.aguchi@hds.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox