From: Fabio Estevam <festevam@gmail.com>
To: vinod.koul@intel.com
Cc: shawn.guo@linaro.org, linux-kernel@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>
Subject: [PATCH] dma: mxs-dma: Convert to devm_ioremap_resource()
Date: Mon, 11 Mar 2013 20:50:33 -0300 [thread overview]
Message-ID: <1363045833-6690-1-git-send-email-festevam@gmail.com> (raw)
Converting to devm_ioremap_resource() can make the code cleaner and smaller.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/dma/mxs-dma.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index 8f6d30d..8a9939e4 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -689,16 +689,9 @@ static int __init mxs_dma_probe(struct platform_device *pdev)
mxs_dma->dev_id = dma_type->id;
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
- if (!request_mem_region(iores->start, resource_size(iores),
- pdev->name)) {
- ret = -EBUSY;
- goto err_request_region;
- }
-
- mxs_dma->base = ioremap(iores->start, resource_size(iores));
- if (!mxs_dma->base) {
- ret = -ENOMEM;
+ mxs_dma->base = devm_ioremap_resource(&pdev->dev, iores);
+ if (IS_ERR(mxs_dma->base)) {
+ ret = PTR_ERR(mxs_dma->base);
goto err_ioremap;
}
@@ -761,10 +754,7 @@ static int __init mxs_dma_probe(struct platform_device *pdev)
err_init:
clk_put(mxs_dma->clk);
err_clk:
- iounmap(mxs_dma->base);
-err_ioremap:
- release_mem_region(iores->start, resource_size(iores));
-err_request_region:
+err_ioremap:
kfree(mxs_dma);
return ret;
}
--
1.7.9.5
next reply other threads:[~2013-03-11 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:50 Fabio Estevam [this message]
2013-03-12 12:04 ` [PATCH] dma: mxs-dma: Convert to devm_ioremap_resource() Shawn Guo
2013-03-12 12:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363045833-6690-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox