From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 3/6] perf util: Remove unnecessary calc_data_size variable
Date: Wed, 13 Mar 2013 20:19:42 +0900 [thread overview]
Message-ID: <1363173585-9754-4-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1363173585-9754-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
It's not set from anywhere so no need to keep it. Looks like an
unneeded copy of the same variable in trace-event-read.c
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/trace-event-info.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index b0bbd76f4a56..783ab51e3ff7 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -119,17 +119,10 @@ static void put_tracing_file(char *file)
free(file);
}
-static ssize_t calc_data_size;
-
static ssize_t write_or_die(const void *buf, size_t len)
{
int ret;
- if (calc_data_size) {
- calc_data_size += len;
- return len;
- }
-
ret = write(output_fd, buf, len);
if (ret < 0)
die("writing to '%s'", output_file);
--
1.7.11.7
next prev parent reply other threads:[~2013-03-13 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 11:19 [PATCH 0/6] perf util: Cleanup trace related files Namhyung Kim
2013-03-13 11:19 ` [PATCH 1/6] perf util: Remove unused trace_read_data function Namhyung Kim
2013-03-21 11:32 ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 2/6] perf util: Remove unused struct definitions Namhyung Kim
2013-03-21 11:33 ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` Namhyung Kim [this message]
2013-03-21 11:34 ` [tip:perf/core] perf tools: Remove unnecessary calc_data_size variable tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 4/6] perf util: Remove unused macro definitions Namhyung Kim
2013-03-21 11:35 ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 5/6] perf util: Remove duplicated page_size definition Namhyung Kim
2013-03-21 11:37 ` [tip:perf/core] perf tools: " tip-bot for Namhyung Kim
2013-03-13 11:19 ` [PATCH 6/6] perf util: Change trace info output file name Namhyung Kim
2013-03-13 13:47 ` David Ahern
2013-03-14 8:23 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363173585-9754-4-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox