From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH] export.h: clarify comment in relation to avoiding includes
Date: Thu, 14 Mar 2013 09:26:13 -0400 [thread overview]
Message-ID: <1363267573-2146-1-git-send-email-paul.gortmaker@windriver.com> (raw)
The existing comment indicated what was desired, but it didn't
necessarily convey the reasoning behind it in an effective way.
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
include/linux/export.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/export.h b/include/linux/export.h
index 696c0f4..d14cf26 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -5,8 +5,9 @@
* to reduce the amount of pointless cruft we feed to gcc when only
* exporting a simple symbol or two.
*
- * If you feel the need to add #include <linux/foo.h> to this file
- * then you are doing something wrong and should go away silently.
+ * More specifically, it was all the #include <linux/foo.h> lines in
+ * module.h that we wanted to avoid, so please avoid adding any such
+ * similar include lines here, if at all possible.
*/
/* Some toolchains use a `_' prefix for all user symbols. */
--
1.8.1.2
next reply other threads:[~2013-03-14 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:26 Paul Gortmaker [this message]
2013-03-15 4:54 ` [PATCH] export.h: clarify comment in relation to avoiding includes Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363267573-2146-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox