From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755038Ab3CSM7m (ORCPT ); Tue, 19 Mar 2013 08:59:42 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:54402 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421Ab3CSM7l (ORCPT ); Tue, 19 Mar 2013 08:59:41 -0400 Message-ID: <1363697977.22553.44.camel@laptop> Subject: Re: [PATCH 1/8] sched: change position of resched_cpu() in load_balance() From: Peter Zijlstra To: Joonsoo Kim Cc: Ingo Molnar , Srivatsa Vaddagiri , linux-kernel@vger.kernel.org Date: Tue, 19 Mar 2013 13:59:37 +0100 In-Reply-To: <1360820921-2513-2-git-send-email-iamjoonsoo.kim@lge.com> References: <1360820921-2513-1-git-send-email-iamjoonsoo.kim@lge.com> <1360820921-2513-2-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote: > cur_ld_moved is reset if env.flags hit LBF_NEED_BREAK. > So, there is possibility that we miss doing resched_cpu(). > Correct it as changing position of resched_cpu() > before checking LBF_NEED_BREAK. > > Signed-off-by: Joonsoo Kim Acked-by: Peter Zijlstra