From: Peter Zijlstra <peterz@infradead.org>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] sched: prevent to re-select dst-cpu in load_balance()
Date: Wed, 20 Mar 2013 13:38:16 +0100 [thread overview]
Message-ID: <1363783096.3724.5.camel@laptop> (raw)
In-Reply-To: <20130320074330.GE11672@lge.com>
On Wed, 2013-03-20 at 16:43 +0900, Joonsoo Kim wrote:
> On Tue, Mar 19, 2013 at 04:05:46PM +0100, Peter Zijlstra wrote:
> > On Thu, 2013-02-14 at 14:48 +0900, Joonsoo Kim wrote:
> > > Commit 88b8dac0 makes load_balance() consider other cpus in its group.
> > > But, in that, there is no code for preventing to re-select dst-cpu.
> > > So, same dst-cpu can be selected over and over.
> > >
> > > This patch add functionality to load_balance() in order to exclude
> > > cpu which is selected once.
> >
> > Oh man.. seriously? Did you see this happen? Also, can't we simply
> > remove it from lb->cpus?
>
> I didn't see it, I do just logical thinking. :)
> lb->cpus is for source cpus and dst-cpu is for dest cpus. So, it doesn't
> works to remove it from lb->cpus.
How about we interpret ->cpus as the total mask to balance; so both
source and destination. That way clearing a cpu means we won't take nor
put tasks on it.
next prev parent reply other threads:[~2013-03-20 12:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 5:48 [PATCH 0/8] correct load_balance() Joonsoo Kim
2013-02-14 5:48 ` [PATCH 1/8] sched: change position of resched_cpu() in load_balance() Joonsoo Kim
2013-03-19 12:59 ` Peter Zijlstra
2013-02-14 5:48 ` [PATCH 2/8] sched: explicitly cpu_idle_type checking in rebalance_domains() Joonsoo Kim
2013-03-19 14:02 ` Peter Zijlstra
2013-03-20 6:48 ` Joonsoo Kim
2013-02-14 5:48 ` [PATCH 3/8] sched: don't consider other cpus in our group in case of NEWLY_IDLE Joonsoo Kim
2013-03-19 14:20 ` Peter Zijlstra
2013-03-20 6:52 ` Joonsoo Kim
2013-02-14 5:48 ` [PATCH 4/8] sched: clean up move_task() and move_one_task() Joonsoo Kim
2013-03-19 14:30 ` Peter Zijlstra
2013-03-20 7:33 ` Joonsoo Kim
2013-03-20 11:11 ` Peter Zijlstra
2013-03-20 13:42 ` JoonSoo Kim
2013-03-20 11:16 ` Peter Zijlstra
2013-03-20 12:07 ` Peter Zijlstra
2013-02-14 5:48 ` [PATCH 5/8] sched: move up affinity check to mitigate useless redoing overhead Joonsoo Kim
2013-02-14 5:48 ` [PATCH 6/8] sched: rename load_balance_tmpmask to load_balance_cpu_active Joonsoo Kim
2013-03-19 15:01 ` Peter Zijlstra
2013-03-20 7:35 ` Joonsoo Kim
2013-02-14 5:48 ` [PATCH 7/8] sched: prevent to re-select dst-cpu in load_balance() Joonsoo Kim
2013-03-19 15:05 ` Peter Zijlstra
2013-03-20 7:43 ` Joonsoo Kim
2013-03-20 12:38 ` Peter Zijlstra [this message]
2013-03-20 13:48 ` JoonSoo Kim
2013-02-14 5:48 ` [PATCH 8/8] sched: reset lb_env when redo " Joonsoo Kim
2013-03-19 15:21 ` Peter Zijlstra
2013-03-20 8:13 ` Joonsoo Kim
2013-02-25 4:56 ` [PATCH 0/8] correct load_balance() Joonsoo Kim
2013-03-19 5:11 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363783096.3724.5.camel@laptop \
--to=peterz@infradead.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox