* [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c
@ 2013-03-22 15:53 Doug Anderson
2013-03-25 9:50 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Doug Anderson @ 2013-03-22 15:53 UTC (permalink / raw)
To: Kukjin Kim
Cc: Thomas Abraham, Stephen Warren, Changhwan Youn, Arnd Bergmann,
Olof Johansson, Simon Glass, Doug Anderson, John Stultz,
Thomas Gleixner, linux-kernel
The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the
end. On my system this causes a compile-time error that looks like:
.../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of distinct pointer types lacks a cast [enabled by default]
.../drivers/clocksource/exynos_mct.c:558:1: error: expected ',' or ';' before 'static'
The error didn't show up till now because there was an extra semicolon
at end of the CLOCKSOURCE_OF_DECLARE definition that was removed by
Arnd Bergmann in "clocksource: make CLOCKSOURCE_OF_DECLARE type safe"
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/clocksource/exynos_mct.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index 203ac05..106228d 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -554,5 +554,5 @@ void __init mct_init(void)
exynos4_clocksource_init();
exynos4_clockevent_init();
}
-CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
-CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
+CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init);
+CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init);
--
1.8.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c
2013-03-22 15:53 [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c Doug Anderson
@ 2013-03-25 9:50 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2013-03-25 9:50 UTC (permalink / raw)
To: 'Doug Anderson'
Cc: 'Thomas Abraham', 'Stephen Warren',
'Changhwan Youn', 'Arnd Bergmann',
'Olof Johansson', 'Simon Glass',
'John Stultz', 'Thomas Gleixner', linux-kernel
Doug Anderson wrote:
>
> The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the
> end. On my system this causes a compile-time error that looks like:
>
> .../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of
> distinct pointer types lacks a cast [enabled by default]
> .../drivers/clocksource/exynos_mct.c:558:1: error: expected ',' or ';'
> before 'static'
>
> The error didn't show up till now because there was an extra semicolon
Yeah.
> at end of the CLOCKSOURCE_OF_DECLARE definition that was removed by
> Arnd Bergmann in "clocksource: make CLOCKSOURCE_OF_DECLARE type safe"
>
OK, thanks.
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> drivers/clocksource/exynos_mct.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index 203ac05..106228d 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -554,5 +554,5 @@ void __init mct_init(void)
> exynos4_clocksource_init();
> exynos4_clockevent_init();
> }
> -CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init)
> -CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init)
> +CLOCKSOURCE_OF_DECLARE(exynos4210, "samsung,exynos4210-mct", mct_init);
> +CLOCKSOURCE_OF_DECLARE(exynos4412, "samsung,exynos4412-mct", mct_init);
> --
> 1.8.1.3
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-22 15:53 [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c Doug Anderson
2013-03-25 9:50 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).