From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com
Subject: Re: [PATCH v5 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU
Date: Mon, 25 Mar 2013 12:43:08 +0100 [thread overview]
Message-ID: <1364211788.5053.3.camel@laptop> (raw)
In-Reply-To: <1363949499-3728-3-git-send-email-eranian@google.com>
On Fri, 2013-03-22 at 11:51 +0100, Stephane Eranian wrote:
> In the 4th version, we renamed the sysfs file to be more
> consistent with the other /proc/sys/kernel entries for
> perf_events.
> static struct device_attribute pmu_dev_attrs[] = {
> - __ATTR_RO(type),
> - __ATTR_NULL,
> + __ATTR_RO(type),
> + __ATTR_RW(perf_event_mux_interval_ms),
> + __ATTR_NULL,
> };
but but but, the file doesn't live in /proc/sys/kernel/, its in
/sys/bus/event_source/devices/*/$foo and none of the files there are
perf_event_* prefixed.
Other than that, the patches look fine.
next prev parent reply other threads:[~2013-03-25 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 10:51 [PATCH v5 0/2] perf: use hrtimer for event multiplexing Stephane Eranian
2013-03-22 10:51 ` [PATCH v5 1/2] " Stephane Eranian
2013-03-25 11:13 ` Peter Zijlstra
2013-03-25 17:58 ` Stephane Eranian
2013-03-22 10:51 ` [PATCH v5 2/2] perf: add sysfs entry to adjust multiplexing interval per PMU Stephane Eranian
2013-03-25 11:43 ` Peter Zijlstra [this message]
2013-03-25 12:15 ` Stephane Eranian
2013-03-22 13:54 ` [PATCH v5 0/2] perf: use hrtimer for event multiplexing Frederic Weisbecker
2013-03-25 12:08 ` Peter Zijlstra
2013-03-25 12:21 ` Frederic Weisbecker
2013-03-22 17:33 ` Andi Kleen
2013-03-22 17:36 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364211788.5053.3.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox