public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the char-misc tree
@ 2013-03-26  4:18 Stephen Rothwell
  2013-03-26 18:20 ` [PATCH] mfd: pm8921: Disable driver until it gets fixed David Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2013-03-26  4:18 UTC (permalink / raw)
  To: Greg KH, Arnd Bergmann
  Cc: linux-next, linux-kernel, Kenneth Heitke, David Brown

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Hi all,

After merging the char-misc tree, today's linux-next build
(x86_64_allmodconfig) failed like this:

drivers/input/keyboard/pmic8xxx-keypad.c:24:35: fatal error: linux/mfd/pm8xxx/gpio.h: No such file or directory

Caused by commit e44b0ceee4cc ("add single-wire serial bus interface
(SSBI) driver") which added the Kconfig symbol MSM_SSBI (later changed to
just SSBI) which did not exist in the tree before.  However,
MFD_PM8921_CORE depended on it and that selects MFD_PM8XXX which allows
the above file to build (and fail).

I have used the char-misc tree from next-20130325 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] mfd: pm8921: Disable driver until it gets fixed
  2013-03-26  4:18 linux-next: build failure after merge of the char-misc tree Stephen Rothwell
@ 2013-03-26 18:20 ` David Brown
  0 siblings, 0 replies; 2+ messages in thread
From: David Brown @ 2013-03-26 18:20 UTC (permalink / raw)
  To: Greg KH
  Cc: David Brown, linux-kernel, linux-arm-msm, linux-arm-kernel,
	Stephen Rothwell

The pm8921 driver has been broken for a while now, but was prevented
from compiling because the SSBI bus driver was missing.  Now that SSBI
is present, pm8921 causes compile fails.

Until the pm8921 driver is fixed, mark it as BROKEN to prevent
compiles from failing.

Cc: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David Brown <davidb@codeaurora.org>
---
Someone is working on the pm8921 driver, but we need to disable it
until those patches are posted.

 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 5bfa7bb..b9723a8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -990,7 +990,7 @@ config MFD_PM8XXX
 
 config MFD_PM8921_CORE
 	tristate "Qualcomm PM8921 PMIC chip"
-	depends on SSBI
+	depends on SSBI && BROKEN
 	select MFD_CORE
 	select MFD_PM8XXX
 	help
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-26 18:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26  4:18 linux-next: build failure after merge of the char-misc tree Stephen Rothwell
2013-03-26 18:20 ` [PATCH] mfd: pm8921: Disable driver until it gets fixed David Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox