public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
	Lee Jones <lee.jones@linaro.org>,
	Yvan FILLION <yvan.fillion@stericsson.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH RFT 1/2] regulator: ab8500: Add missing enable_time settings
Date: Wed, 27 Mar 2013 17:47:22 +0800	[thread overview]
Message-ID: <1364377642.13084.0.camel@phoenix> (raw)

Base on the data provide by Bengt Jönsson, add below enable_time settings:

Worst case enable time from data sheet:
Vana: enable time = 140 us
Vaux1/2: enable time = 200 us
Vaux3: enable time = 450 us
Vintcore: enable time = 750 us
Vamic1/2: enable time = 500 us
Vdmic: enable time = 420 us
VTVout: enable time = 500 us
Vaudio: enable time = 140 us
Vusb: enable time = 150 us

This discussion thread is available at: https://lkml.org/lkml/2013/3/26/795

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/ab8500.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 12e2740..1a38524 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -391,6 +391,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= ARRAY_SIZE(ldo_vauxn_voltages),
 			.volt_table	= ldo_vauxn_voltages,
+			.enable_time	= 200,
 		},
 		.load_lp_uA		= 5000,
 		.update_bank		= 0x04,
@@ -412,6 +413,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= ARRAY_SIZE(ldo_vauxn_voltages),
 			.volt_table	= ldo_vauxn_voltages,
+			.enable_time	= 200,
 		},
 		.load_lp_uA		= 5000,
 		.update_bank		= 0x04,
@@ -433,6 +435,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= ARRAY_SIZE(ldo_vaux3_voltages),
 			.volt_table	= ldo_vaux3_voltages,
+			.enable_time	= 450,
 		},
 		.load_lp_uA		= 5000,
 		.update_bank		= 0x04,
@@ -454,6 +457,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= ARRAY_SIZE(ldo_vintcore_voltages),
 			.volt_table	= ldo_vintcore_voltages,
+			.enable_time	= 750,
 		},
 		.load_lp_uA		= 5000,
 		.update_bank		= 0x03,
@@ -506,6 +510,7 @@ static struct ab8500_regulator_info
 			.owner          = THIS_MODULE,
 			.n_voltages     = 1,
 			.min_uV		= 3300000,
+			.enable_time	= 150,
 		},
 		.update_bank            = 0x03,
 		.update_reg             = 0x82,
@@ -520,6 +525,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
 			.min_uV		= 2000000,
+			.enable_time	= 140,
 		},
 		.update_bank		= 0x03,
 		.update_reg		= 0x83,
@@ -535,6 +541,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
 			.min_uV		= 2050000,
+			.enable_time	= 500,
 		},
 		.update_bank		= 0x03,
 		.update_reg		= 0x83,
@@ -550,6 +557,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
 			.min_uV		= 2050000,
+			.enable_time	= 500,
 		},
 		.update_bank		= 0x03,
 		.update_reg		= 0x83,
@@ -565,6 +573,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
 			.min_uV		= 1800000,
+			.enable_time	= 420,
 		},
 		.update_bank		= 0x03,
 		.update_reg		= 0x83,
@@ -584,6 +593,7 @@ static struct ab8500_regulator_info
 			.owner		= THIS_MODULE,
 			.n_voltages	= 1,
 			.min_uV		= 1200000,
+			.enable_time	= 140,
 		},
 		.load_lp_uA		= 1000,
 		.update_bank		= 0x04,
-- 
1.7.10.4




             reply	other threads:[~2013-03-27  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  9:47 Axel Lin [this message]
2013-03-27  9:48 ` [PATCH RFT 2/2] regulator: ab8500: Remove set_voltage_time_sel and delay setting Axel Lin
2013-03-27 10:42   ` Bengt Jönsson
2013-03-27 10:35 ` [PATCH RFT 1/2] regulator: ab8500: Add missing enable_time settings Bengt Jönsson
2013-03-27 23:18 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364377642.13084.0.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=bengt.g.jonsson@stericsson.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yvan.fillion@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox