From: Axel Lin <axel.lin@ingics.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Alexandre Pereira da Silva <aletes.xgr@gmail.com>,
Roland Stigge <stigge@antcom.de>,
linux-kernel@vger.kernel.org
Subject: [RFT][PATCH 2/2] pwm: lpc32xx: Don't change PWM_ENABLE bit in lpc32xx_pwm_config
Date: Sun, 31 Mar 2013 00:06:30 +0800 [thread overview]
Message-ID: <1364659590.15109.5.camel@phoenix> (raw)
In-Reply-To: <1364659529.15109.4.camel@phoenix>
lpc32xx_pwm_config() is supposed to set duty_ns and period_ns,
it should not change PWM_ENABLE bit.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-lpc32xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c
index 1a5075e..ac4d28d 100644
--- a/drivers/pwm/pwm-lpc32xx.c
+++ b/drivers/pwm/pwm-lpc32xx.c
@@ -68,7 +68,7 @@ static int lpc32xx_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
c = 255;
duty_cycles = 256 - c;
- writel(PWM_ENABLE | PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles),
+ writel(PWM_RELOADV(period_cycles) | PWM_DUTY(duty_cycles),
lpc32xx->base + (pwm->hwpwm << 2));
return 0;
--
1.7.10.4
next prev parent reply other threads:[~2013-03-30 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 16:05 [RFT][PATCH 1/2] pwm: lpc32xx: Properly set PWM_ENABLE bit in lpc32xx_pwm_[enable|disable] Axel Lin
2013-03-30 16:06 ` Axel Lin [this message]
2013-03-30 16:24 ` [RFT][PATCH v2 2/2] pwm: lpc32xx: Don't change PWM_ENABLE bit in lpc32xx_pwm_config Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364659590.15109.5.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=aletes.xgr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stigge@antcom.de \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox