Re: [PATCH] regulator: ab8500: Staticize ab8500_ext_regulator_[init|exit] if !CONFIG_REGULATOR_AB8500_EXT

Lee Jones
2013-04-02T12:06:00Z

On Tue, 02 Apr 2013, Mark Brown wrote:

> On Tue, Apr 02, 2013 at 08:20:38AM +0800, Axel Lin wrote:
> > Fix below build errors:
> >
> > LD arch/arm/mach-ux500/built-in.o
> > arch/arm/mach-ux500/board-mop500-regulators.o: In function `ab8500_ext_regulator_init':
>
> Lee?

Ah yes, I see what's happened.

CONFIG_REGULATOR_AB8500_EXT was used to conditionally build the AB8500
External Regulator driver, but now we just 'build it anyway' on Mark's
request. However, the guards are still remaining in some places.

Please don't action this patch. I'll fix it up properly by removing
the surplus guards.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog