* [RFT][PATCH 1/2] regulator: ab8500: Fix list_voltage for fixed voltage regulators
@ 2013-04-02 6:32 Axel Lin
2013-04-02 6:34 ` [RFT][PATCH 2/2] regulator: ab8500: Add missing volt_table setting for AB8540_LDO_TVOUT Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-04-02 6:32 UTC (permalink / raw)
To: Mark Brown
Cc: Bengt Jonsson, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel
commit b080c78a4e447e9c212c207f725999d4e32c5f19
"regulator: ab8500: Update voltage handling for fixed voltage regulators"
remove min_uV settings and set volt_table for all fixed voltage, thus we can not
use regulator_list_voltage_linear now. Use regulator_list_voltage_table instead.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/ab8500.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 09eea32..5fd764e 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -423,14 +423,14 @@ static struct regulator_ops ab8500_regulator_mode_ops = {
.get_optimum_mode = ab8500_regulator_get_optimum_mode,
.set_mode = ab8500_regulator_set_mode,
.get_mode = ab8500_regulator_get_mode,
- .list_voltage = regulator_list_voltage_linear,
+ .list_voltage = regulator_list_voltage_table,
};
static struct regulator_ops ab8500_regulator_ops = {
.enable = ab8500_regulator_enable,
.disable = ab8500_regulator_disable,
.is_enabled = ab8500_regulator_is_enabled,
- .list_voltage = regulator_list_voltage_linear,
+ .list_voltage = regulator_list_voltage_table,
};
/* AB8500 regulator information */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFT][PATCH 2/2] regulator: ab8500: Add missing volt_table setting for AB8540_LDO_TVOUT
2013-04-02 6:32 [RFT][PATCH 1/2] regulator: ab8500: Fix list_voltage for fixed voltage regulators Axel Lin
@ 2013-04-02 6:34 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2013-04-02 6:34 UTC (permalink / raw)
To: Mark Brown
Cc: Bengt Jonsson, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel
This is required for regulator_list_voltage_table() to properly work.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
The setting is copied from AB8500_LDO_TVOUT, I don't have the datasheet.
Can someone test and review if this patch is correct or not?
Axel
drivers/regulator/ab8500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 5fd764e..44602c5 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -1303,6 +1303,7 @@ static struct ab8500_regulator_info
.id = AB8500_LDO_TVOUT,
.owner = THIS_MODULE,
.n_voltages = 1,
+ .volt_table = fixed_2000000_voltage,
},
.load_lp_uA = 1000,
.update_bank = 0x03,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-02 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-02 6:32 [RFT][PATCH 1/2] regulator: ab8500: Fix list_voltage for fixed voltage regulators Axel Lin
2013-04-02 6:34 ` [RFT][PATCH 2/2] regulator: ab8500: Add missing volt_table setting for AB8540_LDO_TVOUT Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox