* [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT
@ 2007-12-06 15:25 Denis Cheng
2007-12-06 15:55 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Denis Cheng @ 2007-12-06 15:25 UTC (permalink / raw)
To: David Howells; +Cc: Andrew Morton, linux-kernel
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
fs/afs/cell.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index 970d38f..b4a09ab 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -20,7 +20,7 @@
DECLARE_RWSEM(afs_proc_cells_sem);
LIST_HEAD(afs_proc_cells);
-static struct list_head afs_cells = LIST_HEAD_INIT(afs_cells);
+static LIST_HEAD(afs_cells);
static DEFINE_RWLOCK(afs_cells_lock);
static DECLARE_RWSEM(afs_cells_sem); /* add/remove serialisation */
static DECLARE_WAIT_QUEUE_HEAD(afs_cells_freeable_wq);
--
1.5.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT
2007-12-06 15:25 [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT Denis Cheng
@ 2007-12-06 15:55 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2007-12-06 15:55 UTC (permalink / raw)
To: Denis Cheng; +Cc: dhowells, Andrew Morton, linux-kernel
Denis Cheng <crquan@gmail.com> wrote:
> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
And mucks up TAGS generation:-/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-06 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-06 15:25 [PATCH 11/20] fs/afs/cell.c: use LIST_HEAD instead of LIST_HEAD_INIT Denis Cheng
2007-12-06 15:55 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox