From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 13/16] extcon: arizona: Time out if MICDET fails to report
Date: Tue, 2 Apr 2013 12:32:45 +0100 [thread overview]
Message-ID: <1364902368-1123-13-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364902368-1123-1-git-send-email-broonie@opensource.wolfsonmicro.com>
In pathological cases the microphone detection may fail to report, for
example due to a failure to get a stable measurement. Provide a timeout
to cover such cases.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/extcon/extcon-arizona.c | 38 +++++++++++++++++++++++++++++++++++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index a83ca27a..e2d881a 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -42,6 +42,7 @@
#define ARIZONA_HPDET_MAX 10000
#define HPDET_DEBOUNCE 500
+#define MICD_TIMEOUT 2000
struct arizona_extcon_info {
struct device *dev;
@@ -63,6 +64,7 @@ struct arizona_extcon_info {
bool micd_clamp;
struct delayed_work hpdet_work;
+ struct delayed_work micd_timeout_work;
bool hpdet_active;
bool hpdet_done;
@@ -730,6 +732,24 @@ err:
info->hpdet_active = false;
}
+static void arizona_micd_timeout_work(struct work_struct *work)
+{
+ struct arizona_extcon_info *info = container_of(work,
+ struct arizona_extcon_info,
+ micd_timeout_work.work);
+
+ mutex_lock(&info->lock);
+
+ dev_dbg(info->arizona->dev, "MICD timed out, reporting HP\n");
+ arizona_identify_headphone(info);
+
+ info->detecting = false;
+
+ arizona_stop_mic(info);
+
+ mutex_unlock(&info->lock);
+}
+
static irqreturn_t arizona_micdet(int irq, void *data)
{
struct arizona_extcon_info *info = data;
@@ -737,6 +757,8 @@ static irqreturn_t arizona_micdet(int irq, void *data)
unsigned int val = 0, lvl;
int ret, i, key;
+ cancel_delayed_work_sync(&info->micd_timeout_work);
+
mutex_lock(&info->lock);
for (i = 0; i < 10 && !(val & 0x7fc); i++) {
@@ -858,6 +880,10 @@ static irqreturn_t arizona_micdet(int irq, void *data)
}
handled:
+ if (info->detecting)
+ schedule_delayed_work(&info->micd_timeout_work,
+ msecs_to_jiffies(MICD_TIMEOUT));
+
pm_runtime_mark_last_busy(info->dev);
mutex_unlock(&info->lock);
@@ -880,10 +906,11 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
struct arizona_extcon_info *info = data;
struct arizona *arizona = info->arizona;
unsigned int val, present, mask;
- bool cancelled;
+ bool cancelled_hp, cancelled_mic;
int ret, i;
- cancelled = cancel_delayed_work_sync(&info->hpdet_work);
+ cancelled_hp = cancel_delayed_work_sync(&info->hpdet_work);
+ cancelled_mic = cancel_delayed_work_sync(&info->micd_timeout_work);
pm_runtime_get_sync(info->dev);
@@ -909,10 +936,14 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
val &= mask;
if (val == info->last_jackdet) {
dev_dbg(arizona->dev, "Suppressing duplicate JACKDET\n");
- if (cancelled)
+ if (cancelled_hp)
schedule_delayed_work(&info->hpdet_work,
msecs_to_jiffies(HPDET_DEBOUNCE));
+ if (cancelled_mic)
+ schedule_delayed_work(&info->micd_timeout_work,
+ msecs_to_jiffies(MICD_TIMEOUT));
+
goto out;
}
info->last_jackdet = val;
@@ -1037,6 +1068,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
info->dev = &pdev->dev;
info->last_jackdet = ~(ARIZONA_MICD_CLAMP_STS | ARIZONA_JD1_STS);
INIT_DELAYED_WORK(&info->hpdet_work, arizona_hpdet_work);
+ INIT_DELAYED_WORK(&info->micd_timeout_work, arizona_micd_timeout_work);
platform_set_drvdata(pdev, info);
switch (arizona->type) {
--
1.7.10.4
next prev parent reply other threads:[~2013-04-02 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:31 [PATCH 0/16] extcon: arizona: Updates for v3.10 Mark Brown
2013-04-02 11:32 ` [PATCH 01/16] mfd: wm5102: Add registers for microphone detection level configuration Mark Brown
2013-04-02 11:32 ` [PATCH 02/16] extcon: arizona: Attempt more microphone measurements Mark Brown
2013-04-02 11:32 ` [PATCH 03/16] extcon: arizona: Allow configuration of button detection Mark Brown
2013-04-02 11:32 ` [PATCH 04/16] extcon: arizona: Don't pulse MICBIAS for HPDET identification Mark Brown
2013-04-02 11:32 ` [PATCH 05/16] extcon: arizona: Allow pull to be disabled on GPIO5 when used for JACKET Mark Brown
2013-04-02 11:32 ` [PATCH 06/16] extcon: arizona: Raise minimum microphone impedance for HPDET method Mark Brown
2013-04-02 11:32 ` [PATCH 07/16] extcon: arizona: Suppress duplicate JACKDET reports Mark Brown
2013-04-02 11:32 ` [PATCH 08/16] extcon: arizona: Check we report a valid impedance Mark Brown
2013-04-02 11:32 ` [PATCH 09/16] extcon: arizona: Tune up HPDET debounce Mark Brown
2013-04-02 11:32 ` [PATCH 10/16] extcon: arizona: Retry HPDET identification for high impedance Mark Brown
2013-04-02 11:32 ` [PATCH 11/16] extcon: arizona: Don't ground flip when using HPDET identification Mark Brown
2013-04-02 11:32 ` [PATCH 12/16] extcon: arizona: Simplify HPDET based identification Mark Brown
2013-04-02 11:32 ` Mark Brown [this message]
2013-04-02 11:32 ` [PATCH 14/16] extcon: arizona: Clear existing button reports before reporting new one Mark Brown
2013-04-02 11:32 ` [PATCH 15/16] extcon: arizona: Allow additional debounce during microphone detection Mark Brown
2013-04-02 11:32 ` [PATCH 16/16] extcon: arizona: Make mic detection timeout configurable Mark Brown
2013-04-03 18:33 ` [PATCH 0/16] extcon: arizona: Updates for v3.10 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364902368-1123-13-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox