From: Sergey Yanovich <ynvich@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chris Ball <cjb@laptop.org>, Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Namjae Jeon <linkinjeon@gmail.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2] wait while adding MMC host to ensure root mounts
Date: Tue, 02 Apr 2013 18:24:49 +0400 [thread overview]
Message-ID: <1364912689.3399.7.camel@host5.opentask.org> (raw)
In-Reply-To: <515ADEDE.3050707@intel.com>
On Tue, 2013-04-02 at 16:36 +0300, Adrian Hunter wrote:
> On my system it is significant:
>
> Before the patch:
>
> [ 1.625623] VFS: Mounted root (ext4 filesystem) readonly on device 179:2.
>
> After the patch:
>
> [ 1.935851] VFS: Mounted root (ext4 filesystem) readonly on device 179:2.
>
> That is an addition of 310 ms which is 19% performance degradation.
Are you sure the delay is caused by mmc?
On my intel laptop (userspace is Debian/unstable):
[ 1.542339] EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
...
[ 2.735851] mmc0: new high speed SD card at address e624
[ 2.742289] mmcblk0: mmc0:e624 SU02G 1.84 GiB
[ 2.752317] mmcblk0: p1
> Please revert the patch.
Chris, could provide a pointer on how to improve the patch?
Maybe introduce mmc_is_hosting_root() and do something like:
- mmc_flush_scheduled_work();
+ if (mmc_is_hosting_root())
+ mmc_flush_scheduled_work();
next prev parent reply other threads:[~2013-04-02 14:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 1:06 [PATCH] wait while adding MMC host to ensure root mounts Sergey Yanovich
2013-03-14 1:23 ` [PATCH v2] " Sergey Yanovich
2013-03-14 4:08 ` Namjae Jeon
2013-03-14 11:57 ` Sergey Yanovich
2013-03-15 2:51 ` Jaehoon Chung
2013-03-22 17:03 ` Chris Ball
2013-03-27 11:13 ` Ulf Hansson
2013-03-27 11:57 ` Chris Ball
2013-04-02 13:36 ` Adrian Hunter
2013-04-02 14:24 ` Sergey Yanovich [this message]
2013-04-04 6:35 ` Adrian Hunter
2013-04-04 10:59 ` Sergey Yanovich
2013-04-04 11:35 ` Adrian Hunter
2013-04-04 12:32 ` Sergey Yanovich
2013-04-13 10:49 ` Sergey Yanovich
2013-04-13 12:52 ` Chris Ball
[not found] ` <CAPDyKFrF8pmo7mfa_1Vi2n=JBFd1h+VULQ1hJB75=DmNx0erdw@mail.gmail.com>
2013-04-13 12:52 ` Sergey Yanovich
2013-03-27 12:28 ` Сергей Янович
2013-04-02 10:13 ` Ulf Hansson
2013-04-02 10:35 ` Sergey Yanovich
2013-04-02 17:45 ` Ulf Hansson
2013-04-02 18:56 ` Sergey Yanovich
2013-03-14 2:47 ` [PATCH] " Greg Kroah-Hartman
2013-03-14 10:28 ` Sergey Yanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364912689.3399.7.camel@host5.opentask.org \
--to=ynvich@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jh80.chung@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).