public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: [PATCH 6/8] perf sort: Cleanup sort__has_sym setting
Date: Fri,  5 Apr 2013 10:26:36 +0900	[thread overview]
Message-ID: <1365125198-8334-7-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1365125198-8334-1-git-send-email-namhyung@kernel.org>

From: Namhyung Kim <namhyung.kim@lge.com>

The sort__has_sym variable is set only if a symbol-related sort key
was added.  Since branch stack and memory sort dimensions are
separated, it doesn't need to be checked from common dimension.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/sort.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index e4388cbda8ce..55217be009bb 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1015,10 +1015,7 @@ int sort_dimension__add(const char *tok)
 				return -EINVAL;
 			}
 			sort__has_parent = 1;
-		} else if (sd->entry == &sort_sym ||
-			   sd->entry == &sort_sym_from ||
-			   sd->entry == &sort_sym_to ||
-			   sd->entry == &sort_mem_daddr_sym) {
+		} else if (sd->entry == &sort_sym) {
 			sort__has_sym = 1;
 		}
 
-- 
1.7.11.7


  parent reply	other threads:[~2013-04-05  1:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05  1:26 [PATCHSET 0/8] perf tools: Cleanup for sort keys (v3) Namhyung Kim
2013-04-05  1:26 ` [PATCH 1/8] perf sort: Reorder HISTC_SRCLINE index Namhyung Kim
2013-05-31 11:24   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-04-05  1:26 ` [PATCH 2/8] perf sort: Add 'addr' sort key Namhyung Kim
2013-04-05  1:26 ` [PATCH 3/8] perf sort: Add 'addr_to/from' " Namhyung Kim
2013-04-05  1:26 ` [PATCH 4/8] perf sort: Update documentation for sort keys Namhyung Kim
2013-04-05  1:26 ` [PATCH 5/8] perf hists: Move column length setting code Namhyung Kim
2013-04-05  1:26 ` Namhyung Kim [this message]
2013-05-31 11:25   ` [tip:perf/core] perf sort: Cleanup sort__has_sym setting tip-bot for Namhyung Kim
2013-04-05  1:26 ` [PATCH 7/8] perf top: Use sort__has_sym Namhyung Kim
2013-05-31 11:26   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-04-05  1:26 ` [PATCH 8/8] perf hist browser: " Namhyung Kim
2013-05-31 11:28   ` [tip:perf/core] perf hists " tip-bot for Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365125198-8334-7-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox