From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
Randy Dunlap <rdunlap@infradead.org>,
Paul Bolle <pebolle@tiscali.nl>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [PATCH v2] RAPL (Running Average Power Limit) driver
Date: Fri, 5 Apr 2013 14:02:03 -0700 [thread overview]
Message-ID: <1365195724-8945-1-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
Changes since V2:
- use 'struct device' instead of raw kobject to represent
RAPL domains
- changed eventfd control interface to use event string
instead of passing file descriptors that cannot be
authenticated in sysfs directory
- clean ups based on v1 reviews
- use kcalloc for arrays
- drop dependencies on X86
- misc cleanups
I don have a checkpatch error which I think it is not valid. I can
fix it by avoiding the macro/adding more lines.
ERROR: Macros with complex values should be enclosed in parenthesis
#735: FILE: platform/x86/intel_rapl.c:735:
+#define RO_PRIMITIVE(name) \
+ primitive_show_fn(name) \
+ static DEVICE_ATTR(name, S_IRUGO, show_##name, NULL)
If i put parenthesis around it to mute the error then it won't compile.
I attempted to come up with a simple version as Greg suggested to
just expose cooling device but then I realized we could lose many
key functionalities partially due to the correlations among RAPL
control knobs. I am still working on this since it is not as simple as
deleting the advanced interfaces, I would have to do some setup based
on best guesses.
Jacob Pan (1):
Introduce Intel RAPL cooling device driver
Documentation/ABI/testing/sysfs-class-intel-rapl | 121 ++
drivers/platform/x86/Kconfig | 9 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/intel_rapl.c | 1285 ++++++++++++++++++++++
drivers/platform/x86/intel_rapl.h | 244 ++++
5 files changed, 1660 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-intel-rapl
create mode 100644 drivers/platform/x86/intel_rapl.c
create mode 100644 drivers/platform/x86/intel_rapl.h
--
1.7.9.5
next reply other threads:[~2013-04-05 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 21:02 Jacob Pan [this message]
2013-04-05 21:02 ` [PATCH v2] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-05 21:06 ` Greg Kroah-Hartman
2013-04-05 21:26 ` Joe Perches
2013-04-05 21:35 ` Greg Kroah-Hartman
2013-04-12 15:32 ` Jacob Pan
2013-04-12 15:39 ` Greg Kroah-Hartman
2013-04-05 21:57 ` Jacob Pan
2013-04-05 21:06 ` [PATCH v2] RAPL (Running Average Power Limit) driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365195724-8945-1-git-send-email-jacob.jun.pan@linux.intel.com \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=pebolle@tiscali.nl \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox