From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: checkpatch: kill the bogus camelcase check
Date: Wed, 10 Apr 2013 08:07:41 -0700 [thread overview]
Message-ID: <1365606461.1942.3.camel@dabdike> (raw)
In-Reply-To: <20130410145213.GA6854@pd.tnic>
On Wed, 2013-04-10 at 16:52 +0200, Borislav Petkov wrote:
> On Wed, Apr 10, 2013 at 07:35:58AM -0700, Joe Perches wrote:
> > or maybe exclude drivers/scsi and include/scsi/
>
> and arch/x86/kvm/emulate.c
Actually, we get this all over drivers. Some of the problems are to do
with the fact that the check is wrong, so it thinks things like this
drm_core_has_MTRR
are studly caps when they're not, but we have a lot of device
programming manual driven studly caps in PCI, ata, ide etc ..
We also have sanctioned use in mm, things like:
SetPageReserved
ClearPageReserved
But the point still stands. When checkpatch warns about this, there's
nothing that the person submitting the patch can do because the usage
was already embedded into the file they're patching.
James
next prev parent reply other threads:[~2013-04-10 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 21:50 checkpatch: kill the bogus camelcase check James Bottomley
2013-04-10 13:26 ` Andy Whitcroft
2013-04-10 14:35 ` Joe Perches
2013-04-10 14:52 ` Borislav Petkov
2013-04-10 15:07 ` James Bottomley [this message]
2013-04-10 15:19 ` Borislav Petkov
2013-04-11 14:45 ` [PATCH] checkpatch: Make camelcase test --strict and less noisy Joe Perches
2013-05-01 12:34 ` Borislav Petkov
2013-05-01 13:50 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365606461.1942.3.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=apw@canonical.com \
--cc=bp@alien8.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox