From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: "backports@vger.kernel.org" <backports@vger.kernel.org>,
Dan Williams <dcbw@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/18] compat: backport ASYNC_DOMAIN_EXCLUSIVE()
Date: Wed, 10 Apr 2013 20:20:18 +0200 [thread overview]
Message-ID: <1365618018.4235.35.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6VAfAvjRs0uZ=jpMjfP5Dz-zEHu3N7t8AUAofZAggrEEQ@mail.gmail.com> (sfid-20130410_192654_321949_A237B6D2)
On Wed, 2013-04-10 at 10:26 -0700, Luis R. Rodriguez wrote:
> > I guess I'd have to review the async API,
>
> Yeap, reviewing the commit noted would help too.
Yeah ... :)
> > What's the use of just this when you don't have things like
> > async_schedule_domain() and async_synchronize_full_domain(), regulator
> > stuff wouldn't compile I think?
>
> You mean is not having the full asynch that deals with all registered
> domains likely to have an issue on the useres of
> async_synchronize_full_domain() ? Lets better ask Dan.
I don't know. However it seems that in order to have an ASYNC_DOMAIN()
or ASYNC_DOMAIN_EXCLUSIVE() you always need to *do* something with it,
so for that you'd also need the functions async_schedule_domain() and
async_synchronize_full_domain() or similar, at least, no?
The point here seems to be making boot faster by starting a bunch of
async probing inside a domain, and then you wait for the entire domain,
so everything that's in that domain can be done in parallel.
Say for example you have 20 SCSI drives. If you look at them serially
then you'd waste much time waiting for the drives. The point here
appears to be that you create a domain (using this macro), then add all
the drives to the domain and then wait for the domain to finish.
However, it seems entirely pointless to backport just a small part of
the API?
johannes
next prev parent reply other threads:[~2013-04-10 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1365593728-5720-1-git-send-email-mcgrof@do-not-panic.com>
[not found] ` <1365593728-5720-7-git-send-email-mcgrof@do-not-panic.com>
[not found] ` <1365600139.4235.4.camel@jlt4.sipsolutions.net>
[not found] ` <CAB=NE6UpP-X1NCTNRnoSdv_bk3ioZdg5bO1zz0U0dqeWVxZdLw@mail.gmail.com>
[not found] ` <1365614413.4235.29.camel@jlt4.sipsolutions.net>
2013-04-10 17:26 ` [PATCH 06/18] compat: backport ASYNC_DOMAIN_EXCLUSIVE() Luis R. Rodriguez
2013-04-10 18:20 ` Johannes Berg [this message]
2013-04-10 19:19 ` Luis R. Rodriguez
2013-04-10 19:27 ` Johannes Berg
2013-04-10 19:32 ` Luis R. Rodriguez
2013-04-10 19:39 ` Johannes Berg
2013-04-10 19:40 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365618018.4235.35.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=dcbw@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox