* [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO
@ 2013-04-12 7:33 Axel Lin
2013-04-12 9:33 ` Bengt Jönsson
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-04-12 7:33 UTC (permalink / raw)
To: Mark Brown
Cc: Bengt Jonsson, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel
The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched.
It looks like a typo in the voltage_mask settings.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Lee and Bengt,
I don't have the datasheet. Can you confirm if this fix is correct?
Thanks,
Axel
drivers/regulator/ab8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index ea182d3..b81ff04 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info
.update_val = 0x02,
.voltage_bank = 0x01,
.voltage_reg = 0x57,
- .voltage_mask = 0x7,
+ .voltage_mask = 0x70,
.voltage_shift = 4,
},
[AB8505_LDO_ANAMIC1] = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO
2013-04-12 7:33 [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO Axel Lin
@ 2013-04-12 9:33 ` Bengt Jönsson
0 siblings, 0 replies; 2+ messages in thread
From: Bengt Jönsson @ 2013-04-12 9:33 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Lee Jones, Yvan FILLION, Liam Girdwood,
linux-kernel@vger.kernel.org
On 04/12/2013 09:33 AM, Axel Lin wrote:
> The voltage_mask and voltage_shift settings of AB8505_LDO_AUDIO are not matched.
> It looks like a typo in the voltage_mask settings.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Lee and Bengt,
> I don't have the datasheet. Can you confirm if this fix is correct?
>
> Thanks,
> Axel
Yes it is correct. The voltage bits are in 0x70. Thank you!
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
> drivers/regulator/ab8500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
> index ea182d3..b81ff04 100644
> --- a/drivers/regulator/ab8500.c
> +++ b/drivers/regulator/ab8500.c
> @@ -1130,7 +1130,7 @@ static struct ab8500_regulator_info
> .update_val = 0x02,
> .voltage_bank = 0x01,
> .voltage_reg = 0x57,
> - .voltage_mask = 0x7,
> + .voltage_mask = 0x70,
> .voltage_shift = 4,
> },
> [AB8505_LDO_ANAMIC1] = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-12 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-12 7:33 [RFT][PATCH] regulator: ab8500: Fix voltage_mask for AB8505_LDO_AUDIO Axel Lin
2013-04-12 9:33 ` Bengt Jönsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox