* [PATCH] CRED: Fix kernel panic upon security_file_alloc() failure.
@ 2011-02-04 18:13 David Howells
2011-02-07 23:55 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2011-02-04 18:13 UTC (permalink / raw)
To: torvalds, akpm
Cc: linux-security-module, linux-kernel, Tetsuo Handa, David Howells
From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
In get_empty_filp() since 2.6.29, file_free(f) is called with f->f_cred == NULL
when security_file_alloc() returned an error. As a result, kernel will panic()
due to put_cred(NULL) call within RCU callback.
Fix this bug by assigning f->f_cred before calling security_file_alloc().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/file_table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/file_table.c b/fs/file_table.c
index c3e89ad..eb36b6b 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -125,13 +125,13 @@ struct file *get_empty_filp(void)
goto fail;
percpu_counter_inc(&nr_files);
+ f->f_cred = get_cred(cred);
if (security_file_alloc(f))
goto fail_sec;
INIT_LIST_HEAD(&f->f_u.fu_list);
atomic_long_set(&f->f_count, 1);
rwlock_init(&f->f_owner.lock);
- f->f_cred = get_cred(cred);
spin_lock_init(&f->f_lock);
eventpoll_init_file(f);
/* f->f_version: 0 */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] CRED: Fix kernel panic upon security_file_alloc() failure.
2011-02-04 18:13 [PATCH] CRED: Fix kernel panic upon security_file_alloc() failure David Howells
@ 2011-02-07 23:55 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2011-02-07 23:55 UTC (permalink / raw)
To: stable; +Cc: dhowells, akpm, linux-security-module, linux-kernel, Tetsuo Handa
From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
In get_empty_filp() since 2.6.29, file_free(f) is called with f->f_cred == NULL
when security_file_alloc() returned an error. As a result, kernel will panic()
due to put_cred(NULL) call within RCU callback.
Fix this bug by assigning f->f_cred before calling security_file_alloc().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/file_table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/file_table.c b/fs/file_table.c
index c3e89ad..eb36b6b 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -125,13 +125,13 @@ struct file *get_empty_filp(void)
goto fail;
percpu_counter_inc(&nr_files);
+ f->f_cred = get_cred(cred);
if (security_file_alloc(f))
goto fail_sec;
INIT_LIST_HEAD(&f->f_u.fu_list);
atomic_long_set(&f->f_count, 1);
rwlock_init(&f->f_owner.lock);
- f->f_cred = get_cred(cred);
spin_lock_init(&f->f_lock);
eventpoll_init_file(f);
/* f->f_version: 0 */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-07 23:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-04 18:13 [PATCH] CRED: Fix kernel panic upon security_file_alloc() failure David Howells
2011-02-07 23:55 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox