From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: mingo@kernel.org, hpa@zytor.com, paulus@samba.org,
linux-kernel@vger.kernel.org, acme@ghostprotocols.net,
tglx@linutronix.de, tt.rantala@gmail.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf: Treat attr.config as u64 in perf_swevent_init()
Date: Thu, 18 Apr 2013 13:17:08 +0200 [thread overview]
Message-ID: <1366283828.19383.7.camel@laptop> (raw)
In-Reply-To: <tip-8176cced706b5e5d15887584150764894e94e02f@git.kernel.org>
On Mon, 2013-04-15 at 03:42 -0700, tip-bot for Tommi Rantala wrote:
> Commit-ID: 8176cced706b5e5d15887584150764894e94e02f
> Gitweb: http://git.kernel.org/tip/8176cced706b5e5d15887584150764894e94e02f
> Author: Tommi Rantala <tt.rantala@gmail.com>
> AuthorDate: Sat, 13 Apr 2013 22:49:14 +0300
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Mon, 15 Apr 2013 11:42:12 +0200
>
> perf: Treat attr.config as u64 in perf_swevent_init()
>
> Trinity discovered that we fail to check all 64 bits of
> attr.config passed by user space, resulting to out-of-bounds
> access of the perf_swevent_enabled array in
> sw_perf_event_destroy().
Gah, I so missed we could hide bits in the top word and then use them
in _destroy().
The alternative is of course to also truncate to int in _destroy(), but
yes keeping the natural size seems the best alternative.
next prev parent reply other threads:[~2013-04-18 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 19:49 [PATCH] perf: treat attr.config as u64 in perf_swevent_init() Tommi Rantala
2013-04-15 10:42 ` [tip:perf/urgent] perf: Treat " tip-bot for Tommi Rantala
2013-04-18 11:17 ` Peter Zijlstra [this message]
2013-04-22 12:33 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366283828.19383.7.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox