* [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10
@ 2013-04-19 12:33 Axel Lin
2013-04-21 9:01 ` Laxman Dewangan
2013-04-22 12:26 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-04-19 12:33 UTC (permalink / raw)
To: Mark Brown; +Cc: Laxman Dewangan, Graeme Gregory, Liam Girdwood, linux-kernel
The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
wrong register for SMPS10 in current code. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/palmas-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 67ed5e5d..9254f94 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -99,6 +99,7 @@ static const struct regs_info palmas_regs_info[] = {
{
.name = "SMPS10",
.sname = "smps10-in",
+ .ctrl_addr = PALMAS_SMPS10_CTRL,
},
{
.name = "LDO1",
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10
2013-04-19 12:33 [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10 Axel Lin
@ 2013-04-21 9:01 ` Laxman Dewangan
2013-04-22 12:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2013-04-21 9:01 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Graeme Gregory, Liam Girdwood,
linux-kernel@vger.kernel.org
On Friday 19 April 2013 06:03 PM, Axel Lin wrote:
> The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
> wrong register for SMPS10 in current code. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10
2013-04-19 12:33 [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10 Axel Lin
2013-04-21 9:01 ` Laxman Dewangan
@ 2013-04-22 12:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-22 12:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Laxman Dewangan, Graeme Gregory, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
On Fri, Apr 19, 2013 at 08:33:45PM +0800, Axel Lin wrote:
> The ctrl_addr setting for SMPS10 is missed, thus palmas_smps_init() read/write
> wrong register for SMPS10 in current code. Fix it.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-22 12:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 12:33 [PATCH] regulator: palmas: Add missing ctrl_addr setting for SMPS10 Axel Lin
2013-04-21 9:01 ` Laxman Dewangan
2013-04-22 12:26 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox