Re: [PATCH v2 1/2] isapnp: remove debug leftovers

Rafael J. Wysocki
2013-04-23T14:26:15Z

On Tuesday, April 23, 2013 04:37:18 PM Andy Shevchenko wrote:
> There are couple of #if 0's to avoid debug printing. Let's remove them as
> Rafael suggested.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Both patches applied.

Thanks,
Rafael

> ---
> drivers/pnp/isapnp/core.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c
> index 918d5f0..cf88f9b6 100644
> --- a/drivers/pnp/isapnp/core.c
> +++ b/drivers/pnp/isapnp/core.c
> @@ -379,10 +379,6 @@ static int __init isapnp_read_tag(unsigned char *type, unsigned short *size)
> *type = (tag >> 3) & 0x0f;
> *size = tag & 0x07;
> }
> -#if 0
> - printk(KERN_DEBUG "tag = 0x%x, type = 0x%x, size = %i\n", tag, *type,
> - *size);
> -#endif
> if (*type == 0xff && *size == 0xffff) /* probably invalid data */
> return -1;
> return 0;
> @@ -813,13 +809,6 @@ static int __init isapnp_build_device_list(void)
> if (!card)
> continue;
>
> -#if 0
> - dev_info(&card->dev,
> - "vendor: %02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x\n",
> - header[0], header[1], header[2], header[3], header[4],
> - header[5], header[6], header[7], header[8]);
> - dev_info(&card->dev, "checksum = %#x\n", checksum);
> -#endif
> INIT_LIST_HEAD(&card->devices);
> card->serial =
> (header[7] << 24) | (header[6] << 16) | (header[5] << 8) |
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.