Re: [PATCH v2 6/6] add documentation on proc.txt

Minchan Kim
2013-04-24T08:18:19Z

Hello Rob,

On Wed, Apr 24, 2013 at 01:49:45AM -0500, Rob Landley wrote:
> On 04/23/2013 08:41:04 PM, Minchan Kim wrote:
> >This patch adds stuff about new reclaim field in proc.txt
> >
> >Cc: Rob Landley <rob@landley.net>
> >Signed-off-by: Minchan Kim <minchan@kernel.org>
> >---
> >
> >Rob, I didn't add your Acked-by because interface was slight changed.
> >I hope you give Acke-by after review again.
> >Thanks.
> >
> > Documentation/filesystems/proc.txt | 22 ++++++++++++++++++++++
> > mm/Kconfig | 7 +------
> > 2 files changed, 23 insertions(+), 6 deletions(-)
> >
> >diff --git a/Documentation/filesystems/proc.txt
> >b/Documentation/filesystems/proc.txt
> >index 488c094..1411ad0 100644
> >--- a/Documentation/filesystems/proc.txt
> >+++ b/Documentation/filesystems/proc.txt
> >@@ -136,6 +136,7 @@ Table 1-1: Process specific entries in /proc
> > maps Memory maps to executables and library files (2.4)
> > mem Memory held by this process
> > root Link to the root directory of this process
> >+ reclaim Reclaim pages in this process
> > stat Process status
> > statm Process memory status information
> > status Process status in human readable form
> >@@ -489,6 +490,27 @@ To clear the soft-dirty bit
> >
> > Any other value written to /proc/PID/clear_refs will have no effect.
> >
> >+The file /proc/PID/reclaim is used to reclaim pages in this process.
> >+To reclaim file-backed pages,
> >+ > echo file > /proc/PID/reclaim
> >+
> >+To reclaim anonymous pages,
> >+ > echo anon > /proc/PID/reclaim
> >+
> >+To reclaim all pages,
> >+ > echo all > /proc/PID/reclaim
> >+
> >+Also, you can specify address range of process so part of address
> >space
> >+will be reclaimed. The format is following as
> >+ > echo addr size-byte > /proc/PID/reclaim
> >+
> >+NOTE: addr should be page-aligned.
>
> And size in bytes should be a multiple of page size?

Not necessary. It's same with madvise that VM handle the page
which includes the byte.

>
> >+
> >+Below is example which try to reclaim 2 pages from 0x100000.
> >+
> >+To reclaim both pages in address range,
> >+ > echo $((1<<20) 8192 > /proc/PID/reclaim
>
> Would you like to balance your parentheses?

Fixed. I will include your Acked-by in next spin.
Thanks!

>
> Acked-by: Rob Landley <rob@landley.net>
>
> Rob

--
Kind regards,
Minchan Kim