* [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel
@ 2013-04-24 3:51 Axel Lin
2013-04-25 10:52 ` Mark Brown
2013-04-28 1:13 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-04-24 3:51 UTC (permalink / raw)
To: Mark Brown
Cc: Matt Sealey, Steev Klimaszewski, Yong Shen, Liam Girdwood,
linux-kernel
It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
untouched may result in wrong voltage setting.
For example, currently switch voltage from 1400000 to 1300000 will set the
voltage to 1800000 because the HI bit is still set.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/mc13892-regulator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 9891aec..cc76c52 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -465,13 +465,13 @@ static int mc13892_sw_regulator_set_voltage_sel(struct regulator_dev *rdev,
*/
if (mc13892_regulators[id].vsel_reg != MC13892_SWITCHERS0) {
+ mask |= MC13892_SWITCHERS0_SWxHI;
+
if (volt > 1375000) {
reg_value -= MC13892_SWxHI_SEL_OFFSET;
reg_value |= MC13892_SWITCHERS0_SWxHI;
- mask |= MC13892_SWITCHERS0_SWxHI;
- } else if (volt < 1100000) {
+ } else {
reg_value &= ~MC13892_SWITCHERS0_SWxHI;
- mask |= MC13892_SWITCHERS0_SWxHI;
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel
2013-04-24 3:51 [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel Axel Lin
@ 2013-04-25 10:52 ` Mark Brown
2013-04-28 1:13 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-25 10:52 UTC (permalink / raw)
To: Axel Lin
Cc: Matt Sealey, Steev Klimaszewski, Yong Shen, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On Wed, Apr 24, 2013 at 11:51:12AM +0800, Axel Lin wrote:
> It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
> voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
> untouched may result in wrong voltage setting.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel
2013-04-24 3:51 [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel Axel Lin
2013-04-25 10:52 ` Mark Brown
@ 2013-04-28 1:13 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-28 1:13 UTC (permalink / raw)
To: Axel Lin
Cc: Matt Sealey, Steev Klimaszewski, Yong Shen, Liam Girdwood,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On Wed, Apr 24, 2013 at 11:51:12AM +0800, Axel Lin wrote:
> It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to the
> voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
> untouched may result in wrong voltage setting.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-28 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-24 3:51 [PATCH] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel Axel Lin
2013-04-25 10:52 ` Mark Brown
2013-04-28 1:13 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox