From: Mike Galbraith <bitbucket@online.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Tim Sander <tim.sander@hbm.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: Re: [ANNOUNCE] 3.4.41-rt55-feat1
Date: Thu, 25 Apr 2013 14:36:14 +0200 [thread overview]
Message-ID: <1366893374.6139.5.camel@marge.simpson.net> (raw)
In-Reply-To: <51792277.8000205@linutronix.de>
On Thu, 2013-04-25 at 14:32 +0200, Sebastian Andrzej Siewior wrote:
> On 04/25/2013 01:14 PM, Tim Sander wrote:
> > Hi
> >
> > I just wanted to test this release but it fails to compile with the the
> > following error:
> >
> > kernel/hrtimer.c: In function '__hrtimer_start_range_ns':
> > kernel/hrtimer.c:1045:7: error: implicit declaration of function
> > 'hrtimer_rt_defer'
> > kernel/hrtimer.c: At top level:
> > kernel/hrtimer.c:1416:12: error: static declaration of 'hrtimer_rt_defer'
> > follows non-static declaration
> > kernel/hrtimer.c:1045:10: note: previous implicit declaration of
> > 'hrtimer_rt_defer' was here
> >
> > The kernelconfig is attached.
>
> You do not have CONFIG_HIGH_RES_TIMERS defined. Is this on purpose?
git@marge:~/linux-2.6> ls -1 arch/arm/configs|wc -l
122
git@marge:~/linux-2.6> grep -IR CONFIG_HIGH_RES_TIMERS arch/arm/configs|wc -l
31
Oh. Sniff, poor little things.
hrtimer: fix hrtimer free zone build bug
Signed-off-by: Mike Galbraith <bitbucket@online.de>
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index 2328c04..31d57a2 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1036,7 +1036,7 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim,
&& hrtimer_enqueue_reprogram(timer, new_base)) {
if (wakeup
-#ifdef CONFIG_PREEMPT_RT_BASE
+#if defined(CONFIG_PREEMPT_RT_BASE) && defined(CONFIG_HIGH_RES_TIMERS)
/*
* Move softirq based timers away from the rbtree in
* case it expired already. Otherwise we would have a
next prev parent reply other threads:[~2013-04-25 12:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 23:44 [ANNOUNCE] 3.4.41-rt55-feat1 Steven Rostedt
2013-04-25 11:14 ` Tim Sander
2013-04-25 12:32 ` Sebastian Andrzej Siewior
2013-04-25 12:36 ` Mike Galbraith [this message]
2013-04-25 12:43 ` Steven Rostedt
2013-04-25 12:46 ` Thomas Gleixner
2013-04-25 12:52 ` Steven Rostedt
2013-04-25 13:09 ` Thomas Gleixner
2013-04-25 13:15 ` Steven Rostedt
2013-04-25 13:23 ` Mike Galbraith
2013-04-25 12:48 ` Mike Galbraith
2013-04-25 12:52 ` Steven Rostedt
2013-04-25 12:55 ` Sebastian Andrzej Siewior
2013-04-25 13:12 ` Mike Galbraith
2013-04-25 14:22 ` Tim Sander
2013-04-25 14:36 ` Steven Rostedt
2013-04-25 22:20 ` Thomas Gleixner
2013-04-25 22:23 ` Steven Rostedt
2013-04-26 6:29 ` Tim Sander
2013-04-25 12:36 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366893374.6139.5.camel@marge.simpson.net \
--to=bitbucket@online.de \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.sander@hbm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox