public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Olivier Langlois <olivier@trillion01.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	schwidefsky@de.ibm.com, Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/3] process cputimer is moving faster than its corresponding clock
Date: Sat, 27 Apr 2013 00:40:06 -0400	[thread overview]
Message-ID: <1367037606.7911.66.camel@Wailaba2> (raw)
In-Reply-To: <517AD0AE.1030404@gmail.com>



Forbids the cputimer to drift ahead of its process clock by
blocking its update when a tick occurs while a autoreaping task
is currently in do_exit() between the call to release_task() and
its final call to schedule().

Any task stats update after having called release_task() will
be lost because they are added to the global process stats located
in the signal struct from release_task().

Ideally, you should postpone the release_task() call after the
final context switch to get all the stats added but this is
more complex to achieve.

In other words, this is slowing down the cputimer so it keep the same
pace than the process clock but in fact, what should be done is to
speed up the process clock by adding the missing stats to it.

Signed-off-by: Olivier Langlois <olivier@trillion01.com>
---
 kernel/sched/fair.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 7a33e59..52d7b10 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -708,7 +708,15 @@ static void update_curr(struct cfs_rq *cfs_rq)
 
                trace_sched_stat_runtime(curtask, delta_exec, curr->vruntime);
                cpuacct_charge(curtask, delta_exec);
-               account_group_exec_runtime(curtask, delta_exec);
+               /*
+                * Do not update the cputimer if the task is already released by
+                * release_task().
+                *
+                * it would preferable to defer the autoreap release_task
+                * after the last context switch but harder to do.
+                */
+               if (likely(curtask->sighand))
+                       account_group_exec_runtime(curtask, delta_exec);
        }
 
        account_cfs_rq_runtime(cfs_rq, delta_exec);
-- 
1.8.2.1




  parent reply	other threads:[~2013-04-27  4:40 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 17:59 [PATCH] process cputimer is moving faster than its corresponding clock Olivier Langlois
2013-04-10 11:35 ` Peter Zijlstra
2013-04-10 15:48   ` Olivier Langlois
2013-04-12  9:16     ` Peter Zijlstra
2013-04-15  1:55       ` Olivier Langlois
2013-04-12  9:18     ` Peter Zijlstra
2013-04-12 10:50     ` Peter Zijlstra
2013-04-12 15:55       ` Peter Zijlstra
2013-04-15  6:11         ` Olivier Langlois
2013-04-19 13:03         ` Frederic Weisbecker
2013-04-19 17:38           ` KOSAKI Motohiro
2013-04-19 18:08             ` KOSAKI Motohiro
2013-04-26  4:40               ` Olivier Langlois
2013-04-26  6:27                 ` Olivier Langlois
2013-04-26 19:08                   ` KOSAKI Motohiro
2013-04-27  1:51                     ` Olivier Langlois
2013-04-27  2:15                       ` KOSAKI Motohiro
2013-04-27  5:02                         ` Olivier Langlois
2013-04-27  5:17                           ` Olivier Langlois
2013-04-27  5:31                           ` Olivier Langlois
2013-04-27  5:06                         ` Olivier Langlois
2013-04-27  4:40                     ` Olivier Langlois [this message]
2013-04-29  0:45                       ` [PATCH v2 1/3] " Frederic Weisbecker
2013-04-29 17:29                         ` Olivier Langlois
2013-04-29  5:06                       ` KOSAKI Motohiro
2013-04-29 17:10                         ` Olivier Langlois
2013-04-29 17:41                           ` Olivier Langlois
2013-04-29 17:56                           ` KOSAKI Motohiro
2013-04-29 18:20                             ` Olivier Langlois
2013-04-29 18:31                               ` KOSAKI Motohiro
2013-04-29 18:54                                 ` Olivier Langlois
2013-04-29 19:09                                   ` KOSAKI Motohiro
2013-04-29 21:20                                     ` Olivier Langlois
2013-04-29 22:42                                       ` KOSAKI Motohiro
     [not found]                     ` <1367036552.7911.63.camel@Wailaba2>
2013-04-27  4:40                       ` [PATCH v2 2/3] " Olivier Langlois
2013-04-27  4:41                       ` [PATCH v2 3/3] " Olivier Langlois
2013-04-29  6:25                         ` KOSAKI Motohiro
2013-04-29 17:16                           ` Olivier Langlois
2013-04-11  3:29   ` [PATCH] " Olivier Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367037606.7911.66.camel@Wailaba2 \
    --to=olivier@trillion01.com \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox