Re: [PATCH] HID: add support for Sony RF receiver with USB product id 0x0374

Fernando Luis Vazquez Cao
2013-01-15T10:04:47Z

Hi Antonio,

On 2013/01/15 18:36, Antonio Ospite wrote:
> On Tue, 15 Jan 2013 12:43:48 +0900 Fernando Luis Vázquez Cao <fernando_b1@lab.ntt.co.jp> wrote:
>> diff -urNp linux-3.8-rc3-orig/drivers/hid/hid-sony.c linux-3.8-rc3/drivers/hid/hid-sony.c
>> --- linux-3.8-rc3-orig/drivers/hid/hid-sony.c 2012-12-11 12:30:57.000000000 +0900
>> +++ linux-3.8-rc3/drivers/hid/hid-sony.c 2013-01-13 18:21:19.901347327 +0900
>> @@ -44,19 +44,21 @@ static __u8 *sony_report_fixup(struct hi
>> struct sony_sc *sc = hid_get_drvdata(hdev);
>>
>> if ((sc->quirks & VAIO_RDESC_CONSTANT) &&
>> - *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> - hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
>> + *rsize >= 56 && rdesc[54] == 0x81 && rdesc[55] == 0x07) {
>> + hid_info(hdev,
>> + "Fixing up Sony RF Receiver report descriptor\n");
> Changing the message does make sense, but try to avoid mixing
> functional changes with style changes (I am referring to the change of
> indentation here).

Oops, that was unintended. I will be replying to this email with an
updated version.

Thanks,
Fernando