public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	James Smart <james.smart@emulex.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: linux-next: Tree for May 6 (lpfc)
Date: Mon, 06 May 2013 09:49:25 -0700	[thread overview]
Message-ID: <1367858965.1868.24.camel@dabdike> (raw)
In-Reply-To: <5187D6F1.9070103@infradead.org>

On Mon, 2013-05-06 at 09:14 -0700, Randy Dunlap wrote:
> On 05/05/13 21:42, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Please do not add any v3.11 destined work to your linux-next included
> > branches until after v3.10-rc1 is released.
> > 
> > I am receiving a (un)reasonable number of conflicts from there being
> > multiple copies of some commits in various trees.   Please clean this up
> > and resist the temptataion to rebase your trees on the way to your
> > upstream ...
> > 
> > Changes since 20130506:
> > 
> 
> on i386:
> # CONFIG_CRC_T10DIF is not set
> 
> 
> drivers/built-in.o: In function `lpfc_bg_crc':
> (.text+0x3cb3c9): undefined reference to `crc_t10dif'

That's the usual minor config cockup, isn't it?  lpfc apparently also
needs the generic checksum, so the fix would seem to be this.

James

---
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index db95c54..86af29f 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1353,6 +1353,8 @@ config SCSI_LPFC
 	tristate "Emulex LightPulse Fibre Channel Support"
 	depends on PCI && SCSI
 	select SCSI_FC_ATTRS
+	select GENERIC_CSUM
+	select CRC_T10DIF
 	help
           This lpfc driver supports the Emulex LightPulse
           Family of Fibre Channel PCI host adapters.



  reply	other threads:[~2013-05-06 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  4:42 linux-next: Tree for May 6 Stephen Rothwell
2013-05-06 16:14 ` linux-next: Tree for May 6 (lpfc) Randy Dunlap
2013-05-06 16:49   ` James Bottomley [this message]
2013-05-06 17:36     ` Martin K. Petersen
2013-05-06 17:48     ` Randy Dunlap
2013-05-06 17:42 ` linux-next: Tree for May 6 (b43/bcma) Randy Dunlap
2013-05-07  3:06   ` Larry Finger
2013-05-07  9:15     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367858965.1868.24.camel@dabdike \
    --to=james.bottomley@hansenpartnership.com \
    --cc=james.smart@emulex.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox