From: Evgeniy Polyakov <zbr@ioremap.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better
Date: Tue, 18 Feb 2014 18:34:07 +0400 [thread overview]
Message-ID: <136801392734047@web14m.yandex.ru> (raw)
In-Reply-To: <20140218082436.GC32652@pengutronix.de>
Hi
18.02.2014, 12:24, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>:
> The thing is that the w1-gpio device might be probed before the gpio's
> controller is available. In this case of_get_gpio returns -EPROBE_DEFER
> and this makes the device core retry probing the w1-gpio device later
> again. So this is not a dt-parsing problem but just dependency stuff.
>
> The 2nd issue addressed didn't happen to me, but it might occur that the
> first of_get_gpio for the data pin succeeds, but the getting the pullup
> gpio fails with -EPROBE_DEFER (e.g. because it sits on a different
> controller). In this case you still want to retry probing later instead
> of ignoring the problem.
>
> Does that make it clearer?
Well, yes, thank you :)
Greg, please pull this patch into your tree.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2014-02-18 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 22:05 [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better Uwe Kleine-König
2014-02-18 1:26 ` zbr
2014-02-18 8:24 ` Uwe Kleine-König
2014-02-18 14:34 ` Evgeniy Polyakov [this message]
2014-02-18 17:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=136801392734047@web14m.yandex.ru \
--to=zbr@ioremap.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox