From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH v3 4/4] xen/arm: account for stolen ticks
Date: Thu, 9 May 2013 09:12:01 +0100 [thread overview]
Message-ID: <1368087121.17285.86.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305081712390.18865@kaball.uk.xensource.com>
On Wed, 2013-05-08 at 18:03 +0100, Stefano Stabellini wrote:
> > What if we have Xen support enabled but don't run as a Xen guest?
>
> That's fine as long as the Xen runstate_memory_area interface is
> available.
> Usually I am a great fun of feature flags, so that every feature can be
> dynamically enabled or disabled and an hypervisor interface can be only
> partially implemented.
>
> However the runstate_memory_area is very old and I would consider it
> one of the core interfaces that need to be available in order to claim
> "Xen compatibility".
I think Marc meant "what if CONFIG_XEN=y but we are running on KVM?". In
that case we wont have set either of the paravirt_steal*_enabled static
keys and so the hook won't be called.
> > > + static_key_slow_inc(¶virt_steal_enabled);
> > > + static_key_slow_inc(¶virt_steal_rq_enabled);
> > > +
Ian.
prev parent reply other threads:[~2013-05-09 8:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:50 [PATCH v3 0/4] xen/arm: CONFIG_PARAVIRT and stolen ticks accounting Stefano Stabellini
2013-05-08 15:41 ` [PATCH v3 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c Stefano Stabellini
2013-05-08 17:54 ` Konrad Rzeszutek Wilk
2013-05-08 18:13 ` Stefano Stabellini
2013-05-09 8:12 ` [Xen-devel] " Ian Campbell
2013-05-08 15:41 ` [PATCH v3 2/4] kernel: missing include in cputime.c Stefano Stabellini
2013-05-08 15:41 ` [PATCH v3 3/4] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops Stefano Stabellini
2013-05-08 16:03 ` Marc Zyngier
2013-05-08 16:07 ` Stefano Stabellini
2013-05-08 15:41 ` [PATCH v3 4/4] xen/arm: account for stolen ticks Stefano Stabellini
2013-05-08 16:07 ` Marc Zyngier
2013-05-08 17:03 ` Stefano Stabellini
2013-05-09 8:12 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368087121.17285.86.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Will.Deacon@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox