From: David Howells <dhowells@redhat.com>
To: Bernd Schmidt <bernds_cb1@t-online.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Wu, Bryan" <Bryan.Wu@analog.com>
Subject: Re: [PATCH, RFD]: Unbreak no-mmu mmap
Date: Fri, 22 Jun 2007 13:59:10 +0100 [thread overview]
Message-ID: <13681.1182517150@redhat.com> (raw)
In-Reply-To: <46695F6D.5050600@t-online.de>
Bernd Schmidt <bernds_cb1@t-online.de> wrote:
> + MAP_PRIVATE | MAP_ANONYMOUS
> + | MAP_GROWSDOWN | MAP_SPLIT_PAGES, 0);
The OR-operator should end the first line.
> diff --git a/include/asm-blackfin/mman.h b/include/asm-blackfin/mman.h
> index 4d504f9..07057b6 100644
> --- a/include/asm-blackfin/mman.h
> +++ b/include/asm-blackfin/mman.h
> @@ -24,6 +24,7 @@
> #define MAP_NONBLOCK 0x10000 /* do not block on IO */
> #define MAP_UNINITIALIZE 0x4000000 /* For anonymous mmap, memory could
> be uninitialized. */
> +#define MAP_SPLIT_PAGES 0x8000000 /* Conserve memory (nommu only). */
Blackfin should really use asm-generic/mman.h if it can.
I'll produce my own version of the patch and pass it back to you once I've got
FRV compiling with it.
David
next prev parent reply other threads:[~2007-06-22 12:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 13:53 [PATCH, RFD]: Unbreak no-mmu mmap Bernd Schmidt
2007-06-09 19:10 ` Matt Mackall
2007-06-11 21:08 ` Robin Getz
2007-06-11 22:09 ` Mike Frysinger
2007-06-11 23:04 ` Bernd Schmidt
2007-06-11 23:22 ` Mike Frysinger
2007-06-19 23:26 ` Robin Getz
2007-06-20 2:38 ` Bryan Wu
2007-06-20 3:00 ` Paul Mundt
2007-06-20 3:18 ` Bryan Wu
2007-06-27 5:50 ` Greg Ungerer
2007-06-22 12:59 ` David Howells [this message]
2007-06-22 13:35 ` David Howells
2007-06-22 14:29 ` [PATCH] NOMMU: " David Howells
2007-08-01 12:29 ` [PATCH, RFD]: " David Howells
2007-08-03 14:03 ` [PATCH] NOMMU: Separate out VMAs David Howells
2007-08-07 13:12 ` Bernd Schmidt
2007-08-07 13:17 ` David Howells
2007-08-07 13:21 ` David Howells
2007-08-07 13:37 ` Bernd Schmidt
2007-08-07 14:03 ` David Howells
2007-08-17 11:49 ` Bernd Schmidt
2007-08-20 15:12 ` David Howells
2007-08-20 16:02 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13681.1182517150@redhat.com \
--to=dhowells@redhat.com \
--cc=Bryan.Wu@analog.com \
--cc=bernds_cb1@t-online.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox