public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: linux-kernel@vger.kernel.org
Cc: alan@redhat.com
Subject: [PATCH] (ac only) quota deadlocks on unmount
Date: Mon, 15 Oct 2001 15:16:39 -0400	[thread overview]
Message-ID: <136890000.1003173399@tiny> (raw)


Hello everyone,

Alan, you're cc'd as an FYI, don't apply this until you get
verification from someone who knows the quota code ;-)

dqput_blocks can return 0 when dqput might decide to call
commit_dqout.  This is bad because remove_inode_dquot_ref
is called with the inode_lock held, and commit_dquot can
trigger schedules or another attempt on the inode_lock.

This is working for me:

-chris

Index: 0.43/fs/dquot.c
--- 0.43/fs/dquot.c Mon, 15 Oct 2001 03:51:05 -0400
+++ 0.43(w)/fs/dquot.c Mon, 15 Oct 2001 14:12:57 -0400
@@ -1246,6 +1246,8 @@
 {
 	if (dquot->dq_dup_ref && dquot->dq_count - dquot->dq_dup_ref <= 1)
 		return 1;
+	if (dquot->dq_count <= 1 && dquot->dq_flags & DQ_MOD) 
+		return 1; 
 	return 0;
 }
 


                 reply	other threads:[~2001-10-15 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=136890000.1003173399@tiny \
    --to=mason@suse.com \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox