From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
David Cohen <david.a.cohen@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH 2/4] gpio-langwell: amend error messages
Date: Tue, 21 May 2013 13:33:04 +0300 [thread overview]
Message-ID: <1369132386-11725-3-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1369132386-11725-1-git-send-email-andriy.shevchenko@linux.intel.com>
Instead of hardcoded names let's use __func__ macro.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-langwell.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index c1f33dd..ab797cc 100644
--- a/drivers/gpio/gpio-langwell.c
+++ b/drivers/gpio/gpio-langwell.c
@@ -392,7 +392,7 @@ static int lnw_gpio_probe(struct pci_dev *pdev,
pci_set_drvdata(pdev, lnw);
retval = gpiochip_add(&lnw->chip);
if (retval) {
- dev_err(&pdev->dev, "langwell gpiochip_add error %d\n", retval);
+ dev_err(&pdev->dev, "%s error %d\n", __func__, retval);
goto err_ioremap;
}
@@ -459,8 +459,7 @@ static int wp_gpio_probe(struct platform_device *pdev)
gc->can_sleep = 0;
retval = gpiochip_add(gc);
if (retval) {
- dev_err(&pdev->dev, "whitneypoint gpiochip_add error %d\n",
- retval);
+ dev_err(&pdev->dev, "%s error %d\n", __func__, retval);
goto err_ioremap;
}
platform_set_drvdata(pdev, lnw);
--
1.8.2.rc0.22.gb3600c3
next prev parent reply other threads:[~2013-05-21 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 10:33 [PATCH 0/4] gpio-langwell: bugfix and amendments Andy Shevchenko
2013-05-21 10:33 ` [PATCH 1/4] gpio-langwell: initialize lock before usage Andy Shevchenko
2013-05-21 10:33 ` Andy Shevchenko [this message]
2013-05-21 10:33 ` [PATCH 3/4] gpio-langwell: do not use direct access to iomapped memory Andy Shevchenko
2013-05-21 10:33 ` [PATCH 4/4] gpio-langwell: use managed functions pcim_* and devm_* Andy Shevchenko
2013-05-21 17:23 ` [PATCH 0/4] gpio-langwell: bugfix and amendments David Cohen
2013-05-21 17:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369132386-11725-3-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=david.a.cohen@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox