From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 3/7] mfd: arizona: Add missing cleanup on remove
Date: Tue, 21 May 2013 13:13:17 -0500 [thread overview]
Message-ID: <1369160001-4019-3-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1369160001-4019-1-git-send-email-broonie@opensource.wolfsonmicro.com>
We'd forgotten to disable /RESET or the regulators. Practically speaking
this code is unlikely to ever be run.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 25bfd1e..8002e2d 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -839,6 +839,11 @@ int arizona_dev_exit(struct arizona *arizona)
arizona_free_irq(arizona, ARIZONA_IRQ_CLKGEN_ERR, arizona);
pm_runtime_disable(arizona->dev);
arizona_irq_exit(arizona);
+ if (arizona->pdata.reset)
+ gpio_set_value_cansleep(arizona->pdata.reset, 0);
+ regulator_disable(arizona->dcvdd);
+ regulator_bulk_disable(ARRAY_SIZE(arizona->core_supplies),
+ arizona->core_supplies);
return 0;
}
EXPORT_SYMBOL_GPL(arizona_dev_exit);
--
1.7.10.4
next prev parent reply other threads:[~2013-05-21 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 18:12 [PATCH 0/7] mfd: arizona: Updates for v3.11 Mark Brown
2013-05-21 18:13 ` [PATCH 1/7] mfd: arizona: Read the device identification information after boot Mark Brown
2013-05-21 18:13 ` [PATCH 2/7] mfd: wm5102: Manually apply register patch Mark Brown
2013-05-21 18:13 ` Mark Brown [this message]
2013-05-21 18:13 ` [PATCH 4/7] mfd: arizona: Disable interrupts during suspend Mark Brown
2013-05-21 18:13 ` [PATCH 5/7] mfd: Add device tree bindings for Arizona class devices Mark Brown
2013-05-21 18:13 ` [PATCH 6/7] mfd: arizona: Support use of external DCVDD Mark Brown
2013-05-21 18:13 ` [PATCH 7/7] mfd: arizona: Change fast_start pdata name to better reflect functionality Mark Brown
2013-05-24 22:07 ` [PATCH 0/7] mfd: arizona: Updates for v3.11 Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369160001-4019-3-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox