Re: [PATCH] bestcomm: no need to free when kzalloc fail

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Wed, 2013-05-22 at 12:49 +0800, Libo Chen wrote:
> ping...

This is pointless. We routinely avoid adding such crap by having
the various free(...) routines cope with NULL. You just need to make
sure you are indeed NULL in the error case.

Ben.

> On 2013/5/5 16:38, chenlibo.3@gmail.com wrote:
> > From: Libo Chen <libo.chen@huawei.com>
> > 
> > There is no need to free bcom_eng if kzalloc fail
> > 
> > Signed-off-by: Libo Chen <libo.chen@huawei.com>
> > ---
> >  drivers/dma/bestcomm/bestcomm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c
> > index a8c2e29..300ee2d 100644
> > --- a/drivers/dma/bestcomm/bestcomm.c
> > +++ b/drivers/dma/bestcomm/bestcomm.c
> > @@ -400,7 +400,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op)
> >  		printk(KERN_ERR DRIVER_NAME ": "
> >  			"Can't allocate state structure\n");
> >  		rv = -ENOMEM;
> > -		goto error_sramclean;
> > +		goto error_kzalloc;
> >  	}
> >  
> >  	/* Save the node */
> > @@ -449,6 +449,7 @@ error_release:
> >  	release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma));
> >  error_sramclean:
> >  	kfree(bcom_eng);
> > +error_kzalloc:
> >  	bcom_sram_cleanup();
> >  error_ofput:
> >  	of_node_put(op->dev.of_node);
> > 
>