From: David Ahern <dsahern@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: acme@ghostprotocols.net, mingo@kernel.org, fweisbec@gmail.com,
peterz@infradead.org, jolsa@redhat.com, namhyung@kernel.org,
xiaoguangrong@linux.vnet.ibm.com, runzhen@linux.vnet.ibm.com,
David Ahern <dsahern@gmail.com>
Subject: [PATCH 08/16] perf stats: fix divide by 0 in variance
Date: Sat, 25 May 2013 18:24:48 -0600 [thread overview]
Message-ID: <1369527896-3650-9-git-send-email-dsahern@gmail.com> (raw)
In-Reply-To: <1369527896-3650-1-git-send-email-dsahern@gmail.com>
Number of samples needs to be greater 1 to have a variance.
Fixes nan% in perf-kvm-live output.
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Runzhen Wang <runzhen@linux.vnet.ibm.com>
---
tools/perf/util/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2374212..7c59c28 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -37,7 +37,7 @@ double stddev_stats(struct stats *stats)
{
double variance, variance_mean;
- if (!stats->n)
+ if (stats->n < 2)
return 0.0;
variance = stats->M2 / (stats->n - 1);
--
1.7.10.1
next prev parent reply other threads:[~2013-05-26 0:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 0:24 [PATCH 00/16] perf: kvm live mode David Ahern
2013-05-26 0:24 ` [PATCH 01/16] perf evlist: restore methods removed in earlier cleanup David Ahern
2013-05-26 0:24 ` [PATCH 02/16] perf evlist: move tracepoint processing code to evlist.c David Ahern
2013-05-26 0:24 ` [PATCH 03/16 v2] perf evlist: add initialzation function for tracepoints David Ahern
2013-05-26 0:24 ` [PATCH 04/16 v2] perf session: export a few functions for event processing David Ahern
2013-05-26 0:24 ` [PATCH 05/16] perf top: move CONSOLE_CLEAR to header file David Ahern
2013-05-26 0:24 ` [PATCH 06/16] perf kvm: handle realloc failures David Ahern
2013-05-31 11:49 ` [tip:perf/core] perf kvm: Handle " tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 07/16] perf kvm: split out tracepoints from record args David Ahern
2013-05-26 0:24 ` David Ahern [this message]
2013-05-31 11:51 ` [tip:perf/core] perf stats: Fix divide by 0 in variance tip-bot for David Ahern
2013-05-26 0:24 ` [PATCH 09/16] perf stats: add max and min stats David Ahern
2013-05-26 0:24 ` [PATCH 10/16 v2] perf kvm: add live mode David Ahern
2013-05-26 0:24 ` [PATCH 11/16] perf kvm: add min and max stats to display David Ahern
2013-05-26 0:24 ` [PATCH 12/16] perf kvm: option to print events that exceed a threshold David Ahern
2013-05-26 0:24 ` [PATCH 13/16] perf kvm: debug for missing vmexit/vmentry event David Ahern
2013-05-26 0:24 ` [PATCH 14/16] perf kvm: reuse some code of perf_kvm__timerfd_create() David Ahern
2013-09-12 13:08 ` Ingo Molnar
2013-09-12 13:34 ` David Ahern
2013-09-12 13:40 ` Ingo Molnar
2013-10-29 13:23 ` Ingo Molnar
2013-10-29 13:53 ` David Ahern
2013-10-29 13:58 ` Ingo Molnar
2013-05-26 0:24 ` [PATCH 15/16] perf kvm: move the prompt_integer() to /util/top.c David Ahern
2013-05-26 0:24 ` [PATCH 16/16] perf kvm: set live mode refresh time dynamically David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369527896-3650-9-git-send-email-dsahern@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox