* [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver
@ 2013-05-27 2:28 Libo Chen
2013-05-27 6:38 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Libo Chen @ 2013-05-27 2:28 UTC (permalink / raw)
To: JBottomley; +Cc: linux-scsi, linux-kernel, lizefan, libo.chen, gregkh
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/scsi/initio.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
old mode 100644
new mode 100755
index 280d5af..1befc26
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2995,19 +2995,8 @@ static struct pci_driver initio_pci_driver = {
.remove = initio_remove_one,
};
-static int __init initio_init_driver(void)
-{
- return pci_register_driver(&initio_pci_driver);
-}
-
-static void __exit initio_exit_driver(void)
-{
- pci_unregister_driver(&initio_pci_driver);
-}
+module_pci_driver(initio_pci_driver);
MODULE_DESCRIPTION("Initio INI-9X00U/UW SCSI device driver");
MODULE_AUTHOR("Initio Corporation");
MODULE_LICENSE("GPL");
-
-module_init(initio_init_driver);
-module_exit(initio_exit_driver);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver
2013-05-27 2:28 [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver Libo Chen
@ 2013-05-27 6:38 ` James Bottomley
2013-05-27 7:41 ` Libo Chen
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2013-05-27 6:38 UTC (permalink / raw)
To: Libo Chen; +Cc: linux-scsi, linux-kernel, lizefan, gregkh
On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote:
> use module_pci_driver instead of init/exit, make code clean.
For the ancient drivers, like this, the principal is that we really
don't touch except for tested bug fixes. For the current ones (like
mvumi) it's up to the maintainer.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver
2013-05-27 6:38 ` James Bottomley
@ 2013-05-27 7:41 ` Libo Chen
0 siblings, 0 replies; 3+ messages in thread
From: Libo Chen @ 2013-05-27 7:41 UTC (permalink / raw)
To: James Bottomley; +Cc: Libo Chen, linux-scsi, linux-kernel, lizefan, gregkh
On 2013/5/27 14:38, James Bottomley wrote:
> On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote:
>> use module_pci_driver instead of init/exit, make code clean.
>
> For the ancient drivers, like this, the principal is that we really
> don't touch except for tested bug fixes. For the current ones (like
> mvumi) it's up to the maintainer.
>
> James
Hi james,
Thank you for your explanation!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-27 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-27 2:28 [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver Libo Chen
2013-05-27 6:38 ` James Bottomley
2013-05-27 7:41 ` Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox