From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Will Deacon <will.deacon@arm.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, viresh.kumar@linaro.org,
djbw@fb.com
Subject: Re: [PATCH] dmatest: do not allow to interrupt ongoing tests
Date: Mon, 27 May 2013 10:11:07 +0300 [thread overview]
Message-ID: <1369638667.29283.197.camel@smile> (raw)
In-Reply-To: <Pine.LNX.4.64.1305242353210.7187@axis700.grange>
On Fri, 2013-05-24 at 23:55 +0200, Guennadi Liakhovetski wrote:
> On Thu, 23 May 2013, Andy Shevchenko wrote:
>
> > When user interrupts ongoing transfers the dmatest may end up with console
> > lockup, oops, or data mismatch. This patch prevents user to abort any ongoing
> > test.
>
> Personally I would be against such a change. What about interrupting the
> test with rmmod?
> Is it still possible after this your patch or not? If not
> - this doesn't seem like a good idea to me. Why don't we just fix those
> bugs, that you're describing?
The behaviour of the module is returned to the same page by this patch
as it was before (w/o debugfs).
The user can interrupt tests by rmmod, but it will take time up to
timeout.
I appreciate if you can do a deeper analysis of what happened in
case Will reported.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-05-27 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 11:29 [PATCH] dmatest: do not allow to interrupt ongoing tests Andy Shevchenko
2013-05-24 21:55 ` Guennadi Liakhovetski
2013-05-27 7:11 ` Andy Shevchenko [this message]
2013-06-05 17:10 ` Will Deacon
2013-06-05 17:25 ` Guennadi Liakhovetski
2013-06-05 17:33 ` Andy Shevchenko
2013-06-07 0:45 ` Vinod Koul
2013-06-07 8:44 ` Will Deacon
2013-06-07 20:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369638667.29283.197.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=djbw@fb.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox