From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933446Ab3E1IRD (ORCPT ); Tue, 28 May 2013 04:17:03 -0400 Received: from mga02.intel.com ([134.134.136.20]:21608 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933328Ab3E1IQ7 (ORCPT ); Tue, 28 May 2013 04:16:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,756,1363158000"; d="scan'208";a="344243627" From: Andy Shevchenko To: sfi-devel@simplefirmware.org, Len Brown , linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH, resend 1/3] sfi: fix compiler warnings Date: Tue, 28 May 2013 11:16:52 +0300 Message-Id: <1369729014-20974-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 1.8.2.rc0.22.gb3600c3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes the following compiler warnings when build is done by make W=1. drivers/sfi/sfi_acpi.c:154:5: warning: no previous prototype for ‘sfi_acpi_table_parse’ [-Wmissing-prototypes] drivers/sfi/sfi_core.c:164:26: warning: no previous prototype for ‘sfi_map_table’ [-Wmissing-prototypes] drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for ‘sfi_unmap_table’ [-Wmissing-prototypes] Indentation fixes are also included. Signed-off-by: Andy Shevchenko --- drivers/sfi/sfi_acpi.c | 8 ++++---- drivers/sfi/sfi_core.c | 4 ++-- include/linux/sfi_acpi.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/sfi/sfi_acpi.c b/drivers/sfi/sfi_acpi.c index f5b4ca5..728a2e2 100644 --- a/drivers/sfi/sfi_acpi.c +++ b/drivers/sfi/sfi_acpi.c @@ -63,6 +63,7 @@ #include #include +#include #include "sfi_core.h" /* @@ -152,7 +153,7 @@ static void sfi_acpi_put_table(struct acpi_table_header *table) * Find specified table in XSDT, run handler on it and return its return value */ int sfi_acpi_table_parse(char *signature, char *oem_id, char *oem_table_id, - int(*handler)(struct acpi_table_header *)) + int(*handler)(struct acpi_table_header *)) { struct acpi_table_header *table = NULL; struct sfi_table_key key; @@ -175,8 +176,8 @@ int sfi_acpi_table_parse(char *signature, char *oem_id, char *oem_table_id, } static ssize_t sfi_acpi_table_show(struct file *filp, struct kobject *kobj, - struct bin_attribute *bin_attr, char *buf, - loff_t offset, size_t count) + struct bin_attribute *bin_attr, char *buf, + loff_t offset, size_t count) { struct sfi_table_attr *tbl_attr = container_of(bin_attr, struct sfi_table_attr, attr); @@ -199,7 +200,6 @@ static ssize_t sfi_acpi_table_show(struct file *filp, struct kobject *kobj, return cnt; } - void __init sfi_acpi_sysfs_init(void) { u32 tbl_cnt, i; diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c index 1e824fb..296db7a 100644 --- a/drivers/sfi/sfi_core.c +++ b/drivers/sfi/sfi_core.c @@ -161,7 +161,7 @@ static int sfi_verify_table(struct sfi_table_header *table) * Check for common case that we can re-use mapping to SYST, * which requires syst_pa, syst_va to be initialized. */ -struct sfi_table_header *sfi_map_table(u64 pa) +static struct sfi_table_header *sfi_map_table(u64 pa) { struct sfi_table_header *th; u32 length; @@ -189,7 +189,7 @@ struct sfi_table_header *sfi_map_table(u64 pa) * Undoes effect of sfi_map_table() by unmapping table * if it did not completely fit on same page as SYST. */ -void sfi_unmap_table(struct sfi_table_header *th) +static void sfi_unmap_table(struct sfi_table_header *th) { if (!TABLE_ON_PAGE(syst_va, th, th->len)) sfi_unmap_memory(th, TABLE_ON_PAGE(th, th, th->len) ? diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h index 631af63..1a88ef6 100644 --- a/include/linux/sfi_acpi.h +++ b/include/linux/sfi_acpi.h @@ -60,7 +60,7 @@ #define _LINUX_SFI_ACPI_H #ifdef CONFIG_SFI -#include /* struct acpi_table_header */ +#include /* struct acpi_table_header */ extern int sfi_acpi_table_parse(char *signature, char *oem_id, char *oem_table_id, -- 1.8.2.rc0.22.gb3600c3