From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>
Subject: Re: [RFC PATCH v0 1/2] dma: move dw_dmac driver to an own directory
Date: Mon, 03 Jun 2013 11:24:02 +0300 [thread overview]
Message-ID: <1370247842.29283.243.camel@smile> (raw)
In-Reply-To: <CAKohpomwHMP=0hxkv4rLRWty28h6F408wmPq6FU_vixL1X-krA@mail.gmail.com>
On Mon, 2013-06-03 at 10:25 +0530, Viresh Kumar wrote:
> On 31 May 2013 21:20, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> > +obj-$(CONFIG_DW_DMAC) += dw/
>
> > +++ b/drivers/dma/dw/Makefile
> > +obj-$(CONFIG_DW_DMAC) += dw_dmac.o
>
> The lower one should be obj-y += dw_dmac.o as this will always
> be true.
Imagine the case when we choose platform driver to be compiled as a
module. It means both variables set to m.
During compilation we will have core part compiled-in, and platform part
as a module.
I don't think this is what we want.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-06-03 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:50 [RFC PATCH v0 0/2] dw_dmac: move to own folder and split Andy Shevchenko
2013-05-31 15:50 ` [RFC PATCH v0 1/2] dma: move dw_dmac driver to an own directory Andy Shevchenko
2013-06-03 4:55 ` Viresh Kumar
2013-06-03 8:24 ` Andy Shevchenko [this message]
2013-06-03 8:39 ` Viresh Kumar
2013-05-31 15:50 ` [RFC PATCH v0 2/2] dma: dw: split driver to library part and platform code Andy Shevchenko
2013-06-03 5:05 ` [RFC PATCH v0 0/2] dw_dmac: move to own folder and split Viresh Kumar
2013-06-03 12:25 ` Andy Shevchenko
2013-06-03 13:12 ` Viresh Kumar
2013-06-03 13:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370247842.29283.243.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox