From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754337Ab3FDMgb (ORCPT ); Tue, 4 Jun 2013 08:36:31 -0400 Received: from mga09.intel.com ([134.134.136.24]:24545 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587Ab3FDMg3 (ORCPT ); Tue, 4 Jun 2013 08:36:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,799,1363158000"; d="scan'208";a="344530049" From: Andy Shevchenko To: Vinod Koul , linux-kernel@vger.kernel.org, spear-devel , viresh.kumar@linaro.org, Arnd Bergmann , Felipe Balbi Cc: Andy Shevchenko Subject: [PATCH v1 1/4] dw_dmac: don't check resource with devm_ioremap_resource Date: Tue, 4 Jun 2013 15:36:19 +0300 Message-Id: <1370349382-20914-2-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 1.8.2.rc0.22.gb3600c3 In-Reply-To: <1370349382-20914-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1370349382-20914-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar --- drivers/dma/dw_dmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 724083d..2b65ba6 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -1667,14 +1667,11 @@ static int dw_probe(struct platform_device *pdev) int err; int i; - io = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!io) - return -EINVAL; - irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; + io = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(&pdev->dev, io); if (IS_ERR(regs)) return PTR_ERR(regs); -- 1.8.2.rc0.22.gb3600c3