From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org,
spear-devel <spear-devel@list.st.com>,
viresh.kumar@linaro.org, Arnd Bergmann <arnd@arndb.de>,
Felipe Balbi <balbi@ti.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 1/4] dw_dmac: don't check resource with devm_ioremap_resource
Date: Wed, 5 Jun 2013 15:26:43 +0300 [thread overview]
Message-ID: <1370435206-13474-2-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1370435206-13474-1-git-send-email-andriy.shevchenko@linux.intel.com>
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/dw_dmac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 724083d..2b65ba6 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1667,14 +1667,11 @@ static int dw_probe(struct platform_device *pdev)
int err;
int i;
- io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!io)
- return -EINVAL;
-
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
+ io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(&pdev->dev, io);
if (IS_ERR(regs))
return PTR_ERR(regs);
--
1.8.2.rc0.22.gb3600c3
next prev parent reply other threads:[~2013-06-05 12:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 12:26 [PATCH v2 0/4] dw_dmac: move to own folder and split Andy Shevchenko
2013-06-05 12:26 ` Andy Shevchenko [this message]
2013-06-05 12:26 ` [PATCH v2 2/4] dma: move dw_dmac driver to an own directory Andy Shevchenko
2013-06-12 5:08 ` Vinod Koul
2013-06-12 7:43 ` Andy Shevchenko
2013-06-12 7:39 ` Vinod Koul
2013-06-12 8:24 ` Viresh Kumar
2013-06-12 8:27 ` Andy Shevchenko
2013-06-12 7:52 ` Vinod Koul
2013-06-12 8:38 ` Andy Shevchenko
2013-06-12 8:12 ` Vinod Koul
2013-06-12 8:53 ` Viresh Kumar
2013-06-12 8:19 ` Vinod Koul
2013-06-12 9:06 ` Viresh Kumar
2013-06-12 9:07 ` Andy Shevchenko
2013-06-12 9:02 ` Vinod Koul
2013-06-12 9:43 ` Viresh Kumar
2013-06-12 11:36 ` Arnd Bergmann
2013-06-12 9:00 ` Andy Shevchenko
2013-06-12 13:52 ` Hein Tibosch
2013-06-05 12:26 ` [PATCH v2 3/4] dma: dw: split driver to library part and platform code Andy Shevchenko
2013-06-05 12:26 ` [PATCH v2 4/4] dma: dw: add PCI part of the driver Andy Shevchenko
2013-06-11 12:39 ` [PATCH v2 0/4] dw_dmac: move to own folder and split Andy Shevchenko
2013-06-12 5:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370435206-13474-2-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox